Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rm -rf to remove project dir on upgrade? #83

Open
LourensVeen opened this issue Jan 12, 2019 · 0 comments
Open

Use rm -rf to remove project dir on upgrade? #83

LourensVeen opened this issue Jan 12, 2019 · 0 comments

Comments

@LourensVeen
Copy link
Member

We're currently deleting the project directory of a project for which there's an update available using Cerulean's rmdir(). This works fine, but because SFTP doesn't have a recursive delete command, Cerulean has to walk the entire tree over the network connection, which means that something like a miniconda install, with lots of small files, takes 3 minutes to delete.

Since we're already running install.sh via the shell, we might as well use rm -rf to delete the project directory, which should be a lot faster. Perhaps we can still have a fallback to rmdir() if it fails somehow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant