Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for additional authentication methods #204

Open
1 task done
j1mbl3s opened this issue Jun 3, 2024 · 1 comment
Open
1 task done

Add support for additional authentication methods #204

j1mbl3s opened this issue Jun 3, 2024 · 1 comment
Labels
Priority: Low Minor issue or feature with minimal impact; can be addressed later. Status: Accepted This task has been acknowledged and is planned for implementation Type: Feature Request Request of a new future feature

Comments

@j1mbl3s
Copy link

j1mbl3s commented Jun 3, 2024

Avoid duplicated feature requests

  • There are no open or closed feature requests that are related to this request

Description

I would like Plant-it to accept authentication from additional sources, such as forwarded proxy headers (X-Forwarded-User, X-Forwarded-Email, etc.), or maybe OAuth/OIDC but I know that is a larger effort and I'm not sure that whole flow is entirely necessary for this application.
This would allow Plant-it to offload the storage of authentication details to another service (it would still need to keep track of user data, though). SSO would be an option for environments that support it(!).

There would need to be a few additional configs for forwarded auth:

  1. FORWARD_AUTH_ENABLED - true/false value which enables or disables the feature to accept forwarded authentication headers
  2. FORWARD_AUTH_HEADER - string specifying the HTTP header used to pass the user id (i.e. X-Forwarded-User, X-Forwarded-Email, etc)
  3. FORWARD_AUTH_TRUSTED_IP - a list of IPs to accept forwarded authentication from (i.e. from the IP of the incoming request); accept from any IP if it is empty/undefined
@j1mbl3s j1mbl3s added Status: Created The issue has been created but not yet assigned or addressed. Type: Feature Request Request of a new future feature labels Jun 3, 2024
@MDeLuise MDeLuise added Status: Accepted This task has been acknowledged and is planned for implementation Priority: Low Minor issue or feature with minimal impact; can be addressed later. and removed Status: Created The issue has been created but not yet assigned or addressed. labels Jun 4, 2024
@acidRain-burns
Copy link

I would definetly like SSO via OIDC, a templated/generic method might notbe too hard. An example is Komga's implemenation: https://komga.org/docs/installation/oauth2/

I use the generic for my selfhosted PocketID, but many use Google/Microsoft/Apple/GitHub or other selfhosted like KeyCloak and Authelia. The templated method means you dont have to make one for all of these different providers. Hope this helps.

Love the project by the way <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Minor issue or feature with minimal impact; can be addressed later. Status: Accepted This task has been acknowledged and is planned for implementation Type: Feature Request Request of a new future feature
Projects
None yet
Development

No branches or pull requests

3 participants