Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefix to pre-defined ICA mixing matrix #981

Open
tsalo opened this issue Sep 21, 2023 · 0 comments
Open

Add prefix to pre-defined ICA mixing matrix #981

tsalo opened this issue Sep 21, 2023 · 0 comments
Labels
bug issues describing a bug or error found in the project

Comments

@tsalo
Copy link
Member

tsalo commented Sep 21, 2023

          After approving, I noticed one minor thing that may or may not be worth changing. The four-echo integration test uses a pre-defined ICA mixing matrix:

https://github.com/tsalo/tedana/blob/1b97294eaed4e7111aba6a807c4ece38472a7270/tedana/tests/test_integration.py#L304

That file desc-ICA_mixing_static.tsv is copied into the output directory without any name change or prefix addition and then the same content is also appropriately named in sub-01_desc_ICA_mixing.tsv

I don't see this as a major issue for this PR. The one problem I could see it happening is if someone is using another package to run ICA and sending those matricies to tedana. In that case, it would be their responsibility to appropriately name their mixing matrix files.

That said, the supplied mixing matrix is copied without any checks on whether it's overwriting anything:
https://github.com/tsalo/tedana/blob/1b97294eaed4e7111aba6a807c4ece38472a7270/tedana/workflows/tedana.py#L519-L525
This should definitely include a check for io_generator.overwrite That could be added here or in a stand-alone PR.

Originally posted by @handwerkerd in #963 (comment)

@tsalo tsalo added the bug issues describing a bug or error found in the project label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug issues describing a bug or error found in the project
Projects
None yet
Development

No branches or pull requests

1 participant