Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makeSimplicial in NormalToricVarieties occasionally makes the variety incomplete #3576

Open
mahrud opened this issue Nov 11, 2024 · 3 comments

Comments

@mahrud
Copy link
Member

mahrud commented Nov 11, 2024

Here is an example:

needsPackage "NormalToricVarieties"

-- Bruns and Gubeladze Example 5.1
P = convexHull matrix transpose {
    {1,1,1,0,0,0}, {0,1,1,0,0,1},
    {1,1,0,1,0,0}, {0,1,0,1,1,0},
    {1,0,1,0,1,0}, {0,1,0,0,1,1},
    {1,0,0,1,0,1}, {0,0,1,1,1,0},
    {1,0,0,0,1,1}, {0,0,1,1,0,1}}
N = ZZ^5
P = affineImage(id_N | transpose matrix {{-1,-1,-1,-1,-1}}, P)

tally apply(100, i -> (
        X := normalToricVariety P;
        assert isComplete X;
        isComplete makeSimplicial X))

And the result:

o5 = Tally{false => 15}
           true => 85

(I didn't test projectivity because it is slower to check, but of course these should always be projective as well.)

cc: @ggsmith

@ggsmith
Copy link
Contributor

ggsmith commented Nov 11, 2024

Have you tracked down the source of the issue? For example, one could easily image that the random weight w insufficiently random.

Using the optional argument Strategy => 1 for makeSimplicial does seem to eliminate the problem, but it is noticeably slower. Do you have any suggestions about how to handle this feature?

@mahrud
Copy link
Member Author

mahrud commented Nov 11, 2024

I don't have any suggestions for this issue. So far I've just ran it again until the variety is complete (and hoped that it is also projective).

@ggsmith
Copy link
Contributor

ggsmith commented Nov 11, 2024

I wouldn't be surprised if the "random weight vector" used in Strategy => 0 (aka the default) could be improved; remarkable little experimentation went into its selection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants