From 2dc43c9bea97827ef35117539a606e172b63912c Mon Sep 17 00:00:00 2001 From: "felixlotter@gmail.com" Date: Sun, 15 Dec 2024 18:59:15 +0100 Subject: [PATCH 1/2] fixed #3600 --- M2/Macaulay2/packages/gfanInterface.m2 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/M2/Macaulay2/packages/gfanInterface.m2 b/M2/Macaulay2/packages/gfanInterface.m2 index 7751a03df25..83432c907b7 100644 --- a/M2/Macaulay2/packages/gfanInterface.m2 +++ b/M2/Macaulay2/packages/gfanInterface.m2 @@ -753,7 +753,7 @@ gfanConvertToNewRing (PolynomialRing) := R1 -> ( --produced by this method. R1Gens := gens R1; numDigits := length (toString (#R1Gens)); - R2 := (coefficientRing R1) (for i in 1..#R1Gens list ( + R2 := (coefficientRing R1) new Array from (for i in 1..#R1Gens list ( value ("x" | demark ("",for i from 1 to numDigits-(length toString i) list "0") | toString i) ) ); R2Gens := gens R2; From 497f3d5dab04c1050d9bf4bf3f083c3f22c7945c Mon Sep 17 00:00:00 2001 From: felixlotter Date: Mon, 16 Dec 2024 15:37:59 +0100 Subject: [PATCH 2/2] added test Update M2/Macaulay2/packages/gfanInterface.m2 fixed test Co-authored-by: Mahrud Sayrafi fixed test added test --- M2/Macaulay2/packages/gfanInterface.m2 | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/M2/Macaulay2/packages/gfanInterface.m2 b/M2/Macaulay2/packages/gfanInterface.m2 index 83432c907b7..14319517619 100644 --- a/M2/Macaulay2/packages/gfanInterface.m2 +++ b/M2/Macaulay2/packages/gfanInterface.m2 @@ -4436,6 +4436,15 @@ doc/// assert equalMPL(B,Bprime) /// +-- TEST gfanConvertToNewRing x NCAlgebra (cf. #3600) + TEST /// + debug needsPackage "gfanInterface" + R = QQ[a]; + gfanConvertToNewRing(R); + needsPackage "NCAlgebra"; + gfanConvertToNewRing(R) + /// + -- TEST gfanBuchberger TEST /// equalMPL = (A,B) -> set transpose A === set transpose B