[flutter_local_notifications] use melos 2.9.0 and fixed unit tests for zonedScheduled method (#1959)

* [flutter_local_notifications] fixed unit tests for zonedScheduled method

* Swift Format

* ignore example when running unit tests

* have unit tests fail fast and specify to ignore example via yaml

* attempt to specify scopes for unit tests to work on CI

* Revert "attempt to specify scopes for unit tests to work on CI"

This reverts commit ece6192.

* remove --no-select when running tests

* update cirrus unit tests script to run pwd command to narrow melos related issues

* Revert "update cirrus unit tests script to run pwd command to narrow melos related issues"

This reverts commit 52747e4.

* have melos not run pub get in parallel

* update pattern to find packages

* made further changes to match updated melos 3 updates

* update version constraints for min Flutter version to 3.3 and Dart SDK min of 2.18

* Revert "update version constraints for min Flutter version to 3.3 and Dart SDK min of 2.18"

This reverts commit 026f577.

* specify using melos 2.9.0 as using 3.0.0 would require bumping min Flutter SDK version constraint

* use cirrus script from master

* activate melos 2.9.0

* updated contribution guide to specify melos 2.9.0 is used

* restore old melos script

* use melos 2.9.0 for ios integration tests

---------

Co-authored-by: runner <[email protected]>

Author: MaikuB

.cirrus.yml

@@ -5,7 +5,7 @@ task:
   pub_cache:
     folder: ~/.pub-cache
   install_melos_script:
-    - dart pub global activate melos
+    - dart pub global activate melos 2.9.0
   build_script:
     - export PATH="$PATH":"$HOME/.pub-cache/bin"
     - melos bootstrap
@@ -18,7 +18,7 @@ task:
   pub_cache:
     folder: ~/.pub-cache
   install_melos_script:
-    - dart pub global activate melos
+    - dart pub global activate melos 2.9.0
   build_script:
     - export PATH="$PATH":"$HOME/.pub-cache/bin"
     - melos bootstrap
@@ -34,7 +34,7 @@ task:
     - flutter channel stable
     - flutter upgrade
   install_melos_script:
-    - dart pub global activate melos
+    - dart pub global activate melos 2.9.0
   build_script:
     - export PATH="$PATH":"$HOME/.pub-cache/bin"
     - melos bootstrap
@@ -52,7 +52,7 @@ task:
   setup_script:
     - flutter config --enable-macos-desktop
   install_melos_script:
-    - dart pub global activate melos
+    - dart pub global activate melos 2.9.0
   build_script:
     - export PATH="$PATH":"$HOME/.pub-cache/bin"
     - melos bootstrap
@@ -69,7 +69,7 @@ task:
     - apt install cmake ninja-build clang pkg-config libgtk-3-dev -y
     - flutter config --enable-linux-desktop
   install_melos_script:
-    - dart pub global activate melos
+    - dart pub global activate melos 2.9.0
   build_script:
     - export PATH="$PATH":"$HOME/.pub-cache/bin"
     - melos bootstrap
@@ -86,7 +86,7 @@ task:
     - apt install cmake ninja-build clang pkg-config libgtk-3-dev -y
     - flutter config --enable-linux-desktop
   install_melos_script:
-    - dart pub global activate melos
+    - dart pub global activate melos 2.9.0
   build_script:
     - export PATH="$PATH":"$HOME/.pub-cache/bin"
     - melos bootstrap
@@ -103,7 +103,7 @@ task:
     - apt install cmake ninja-build clang pkg-config libgtk-3-dev -y
     - flutter config --enable-linux-desktop
   install_melos_script:
-    - dart pub global activate melos
+    - dart pub global activate melos 2.9.0
   build_script:
     - export PATH="$PATH":"$HOME/.pub-cache/bin"
     - melos bootstrap
@@ -114,7 +114,7 @@ task:
   container:
     image: cirrusci/flutter:stable
   install_melos_script:
-    - dart pub global activate melos
+    - dart pub global activate melos 2.9.0
   test_script:
     - export PATH="$PATH":"$HOME/.pub-cache/bin"
     - melos bootstrap
@@ -125,7 +125,7 @@ task:
   container:
     image: cirrusci/flutter:stable
   install_melos_script:
-    - dart pub global activate melos
+    - dart pub global activate melos 2.9.0
   test_script:
     - export PATH="$PATH":"$HOME/.pub-cache/bin"
     - melos bootstrap
@@ -144,7 +144,7 @@ task:
   pub_cache:
     folder: ~/.pub-cache
   install_melos_script:
-    - dart pub global activate melos
+    - dart pub global activate melos 2.9.0
   install_images_script: sdkmanager "system-images;android-$EMULATOR_API_LEVEL;$ANDROID_ABI"
   install_emulator_script: sdkmanager emulator
   create_device_script:
@@ -180,7 +180,7 @@ task:
     - flutter channel stable
     - flutter upgrade
   install_melos_script:
-    - dart pub global activate melos
+    - dart pub global activate melos 2.9.0
   test_script:
     - export PATH="$PATH":"$HOME/.pub-cache/bin"
     - melos bootstrap

CONTRIBUTING.md

@@ -8,4 +8,6 @@ Contributions are welcome by submitting a PR for to be reviewed. If it's to add
 Please ensure that no analysis issues are found and all tests continue to pass and add/update the tests as appropriate.
 Most of the tests are around verifying the details sent via the platform channel.
 
-For API docs, please try to adhere to the effective Dart documentation guidelines that can be found [here](https://dart.dev/guides/language/effective-dart/documentation).
+For API docs, please try to adhere to the effective Dart documentation guidelines that can be found [here](https://dart.dev/guides/language/effective-dart/documentation).
+
+Managing the monorepo is through the use of [`melos`](https://melos.invertase.dev). Currently the minimum Flutter SDK version supported is 3.0 with a corresponding minimum Dart SDK version of 2.17. This isn't compatible with melos versions 3.0 or newer due to incompatible Dart SDK version constraints. To avoid bumping the plugin's minimum Flutter and Dart SDK version constraints just for the sake of being able to use newer versions of `melos`, version 2.9.0 used. For local development purposes you can activate 2.9.0 by running `dart pub global activate melos 2.9.0`. The cirrus build scripts run the same command to specify `melos` version 2.9.0

flutter_local_notifications/macos/Classes/FlutterLocalNotificationsPlugin.swift

@@ -413,7 +413,7 @@ public class FlutterLocalNotificationsPlugin: NSObject, FlutterPlugin, UNUserNot
             let timeZoneName = arguments[MethodCallArguments.timeZoneName] as! String
             let timeZone = TimeZone.init(identifier: timeZoneName)
             let dateFormatter = ISO8601DateFormatter()
-            dateFormatter.formatOptions = [.withFractionalSeconds, .withInternetDateTime];
+            dateFormatter.formatOptions = [.withFractionalSeconds, .withInternetDateTime]
             let date = dateFormatter.date(from: scheduledDateTime)!
             notification.deliveryDate = date
             notification.deliveryTimeZone = timeZone
@@ -553,7 +553,7 @@ public class FlutterLocalNotificationsPlugin: NSObject, FlutterPlugin, UNUserNot
         let timeZoneName = arguments[MethodCallArguments.timeZoneName] as! String
         let timeZone = TimeZone.init(identifier: timeZoneName)
         let dateFormatter = ISO8601DateFormatter()
-        dateFormatter.formatOptions = [.withFractionalSeconds, .withInternetDateTime];
+        dateFormatter.formatOptions = [.withFractionalSeconds, .withInternetDateTime]
         dateFormatter.timeZone = timeZone
         let date = dateFormatter.date(from: scheduledDateTime)!
         var calendar = Calendar.current

flutter_local_notifications/test/android_flutter_local_notifications_test.dart

@@ -1955,6 +1955,7 @@ void main() {
               'payload': '',
               'timeZoneName': 'Australia/Sydney',
               'scheduledDateTime': convertDateToISO8601String(scheduledDate),
+              'scheduledDateTimeISO8601': scheduledDate.toIso8601String(),
               'platformSpecifics': <String, Object?>{
                 'scheduleMode': 'exactAllowWhileIdle',
                 'icon': null,
@@ -2049,6 +2050,7 @@ void main() {
               'payload': '',
               'timeZoneName': 'Australia/Sydney',
               'scheduledDateTime': convertDateToISO8601String(scheduledDate),
+              'scheduledDateTimeISO8601': scheduledDate.toIso8601String(),
               'matchDateTimeComponents': DateTimeComponents.time.index,
               'platformSpecifics': <String, Object?>{
                 'scheduleMode': 'exactAllowWhileIdle',
@@ -2144,6 +2146,7 @@ void main() {
               'payload': '',
               'timeZoneName': 'Australia/Sydney',
               'scheduledDateTime': convertDateToISO8601String(scheduledDate),
+              'scheduledDateTimeISO8601': scheduledDate.toIso8601String(),
               'matchDateTimeComponents':
                   DateTimeComponents.dayOfWeekAndTime.index,
               'platformSpecifics': <String, Object?>{

flutter_local_notifications/test/ios_flutter_local_notifications_test.dart

@@ -374,6 +374,7 @@ void main() {
               'uiLocalNotificationDateInterpretation':
                   UILocalNotificationDateInterpretation.absoluteTime.index,
               'scheduledDateTime': convertDateToISO8601String(scheduledDate),
+              'scheduledDateTimeISO8601': scheduledDate.toIso8601String(),
               'timeZoneName': 'Australia/Sydney',
               'platformSpecifics': <String, Object?>{
                 'presentAlert': true,
@@ -441,6 +442,7 @@ void main() {
               'uiLocalNotificationDateInterpretation':
                   UILocalNotificationDateInterpretation.absoluteTime.index,
               'scheduledDateTime': convertDateToISO8601String(scheduledDate),
+              'scheduledDateTimeISO8601': scheduledDate.toIso8601String(),
               'timeZoneName': 'Australia/Sydney',
               'matchDateTimeComponents': DateTimeComponents.time.index,
               'platformSpecifics': <String, Object?>{
@@ -509,6 +511,7 @@ void main() {
               'uiLocalNotificationDateInterpretation':
                   UILocalNotificationDateInterpretation.absoluteTime.index,
               'scheduledDateTime': convertDateToISO8601String(scheduledDate),
+              'scheduledDateTimeISO8601': scheduledDate.toIso8601String(),
               'timeZoneName': 'Australia/Sydney',
               'matchDateTimeComponents':
                   DateTimeComponents.dayOfWeekAndTime.index,

flutter_local_notifications/test/macos_flutter_local_notifications_test.dart

@@ -283,6 +283,7 @@ void main() {
               'body': 'notification body',
               'payload': '',
               'scheduledDateTime': convertDateToISO8601String(scheduledDate),
+              'scheduledDateTimeISO8601': scheduledDate.toIso8601String(),
               'timeZoneName': 'Australia/Sydney',
               'platformSpecifics': <String, Object?>{
                 'subtitle': null,
@@ -353,6 +354,7 @@ void main() {
               'body': 'notification body',
               'payload': '',
               'scheduledDateTime': convertDateToISO8601String(scheduledDate),
+              'scheduledDateTimeISO8601': scheduledDate.toIso8601String(),
               'timeZoneName': 'Australia/Sydney',
               'matchDateTimeComponents': DateTimeComponents.time.index,
               'platformSpecifics': <String, Object?>{
@@ -426,6 +428,7 @@ void main() {
               'body': 'notification body',
               'payload': '',
               'scheduledDateTime': convertDateToISO8601String(scheduledDate),
+              'scheduledDateTimeISO8601': scheduledDate.toIso8601String(),
               'timeZoneName': 'Australia/Sydney',
               'matchDateTimeComponents':
                   DateTimeComponents.dayOfWeekAndTime.index,

melos.yaml

@@ -19,54 +19,58 @@ scripts:
     description: Run dart analyzer in a specific package.
   test:unit:
     description: Run unit tests in a specific package.
-    run: melos exec --concurrency=1 -- "flutter test"
-    packageFilters:
-      dirExists:
+    run: melos exec -c 1 -- "flutter test"
+    select-package:
+      dir-exists:
         - test
   test:unit:android:
     description: Runs java unit tests
     run: melos exec -c 1 -- "flutter build apk --debug && cd android && ./gradlew flutter_local_notifications:testDebug"
-    packageFilters:
+    select-package:
       scope: "*example*"
   test:integration:
     run: melos exec -c 1 -- "flutter test integration_test"
     description: Run integration tests
-    packageFilters:
-      dirExists:
+    select-package:
+      dir-exists:
         - integration_test
       scope: "*example*"
   build:example_android:
     run: |
-      melos exec -c 1 --scope="*example*" -- \
+      melos exec -c 1 -- \
         "flutter build apk --debug"
     description: Build a specific example app for Android.
-    packageFilters:
-      dirExists:
+    select-package:
+      dir-exists:
         - android
+      scope: "*example*"
   build:example_ios:
     run: |
-      melos exec -c 1 --scope="*example*" -- \
+      melos exec -c 1 -- \
         "flutter build ios --no-codesign --debug"
     description: Build a specific example app for iOS.
-    packageFilters:
-      dirExists:
+    select-package:
+      dir-exists:
         - ios
+      scope: "*example*"
   build:example_macos:
     run: |
-      melos exec -c 1 --scope="*example*" -- \
+      melos exec -c 1 -- \
         "flutter build macos"
     description: Build a specific example app for macOS.
-    packageFilters:
-      dirExists:
+    select-package:
+      dir-exists:
         - macos
+      scope: "*example*"
   build:example_linux:
     run: |
-      melos exec -c 1 --scope="*example*" -- \
+      melos exec -c 1 -- \
         "flutter build linux"
     description: Build a specific example app for Linux.
-    packageFilters:
-      dirExists:
+    select-package:
+      dir-exists:
         - linux
+      scope: "*example*"
 
   clean:
     run: git clean -x -d -f -q