-
Notifications
You must be signed in to change notification settings - Fork 16
Could *not* using custom elements for all MapML elements be problematic? #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Currently, there is no live DOM for |
Whether live DOM matters or not in this context I don't know. Anyhow that's not always the case, for other MapML elements, e.g.
I can only speculate, I'm concerned about the implications regarding future web compatibility considerations in the case of running BigQuery/HTTP Archive queries where it may be found that element X is already in use in Y amount of web pages, and so the question may then be: is it safe to implement those elements in browsers? Maybe @bkardell or @zcorpan can help inform us whether we should use custom elements for every MapML element, or if it's safe to use |
Wow, very sorry for the incredibly slow reply here - I missed this tag entirely and just accidentally came across it looking for something else. In my opinion (I dont think controversial, and I think in alignment with lots of other advice): You shouldn't be adding to the mess that exists already of using non-standard, undasherized elements in the light dom, or similarly, using elements in a way that is not currently compatible. |
Thanks @bkardell, I think your opinion is in alignment with Simon's advice in Maps4HTML/MapML-Proposal#17 (comment) as well:
I suppose they used spans because custom elements wasn't a thing (or widely supported) at the time. We should be able to use the desired names, only dasherized. |
Closing in favor of #511. |
Consider the following markup from mapMLFeatures.html:
for the same reason (future web compat considerations?) we're using
<layer->
as opposed to<layer>
, could this be problematic?I keep stirring the pot.
The text was updated successfully, but these errors were encountered: