-
Notifications
You must be signed in to change notification settings - Fork 16
Should untitled layers be exposed in the layer list UI? #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think untitled/labelled layers should be presented, because you can hide layers you don't want shown by adding the |
Currently, when GeoJSON layers (with no label) are pasted to the mapml-viewer, they get a default localized name of "Layer". I wonder if the same semantics should be used for untitled/unlabeled layers. For ex. Pasting the following geojson to a mapml-viewer results in a new layer with the "Layer" label: |
To test this bug, add the following layer to the sandbox: <layer- checked>
<map-meta name="projection" content="OSMTILE"></map-meta><map-feature zoom="10">
<map-featurecaption>Copied OSMTILE gcrs location</map-featurecaption>
<map-properties>
<h2>Copied OSMTILE gcrs location</h2>
<div style="text-align:center">-75.866089 45.463020</div>
</map-properties>
<map-geometry cs="gcrs">
<map-point>
<map-coordinates>-75.866089 45.463020</map-coordinates>
</map-point>
</map-geometry>
</map-feature>
</layer-> The layer shows up as |
Ensure layer name is not undefined for pasted content --------- Co-authored-by: Peter Rushforth <[email protected]> Co-authored-by: Mu <[email protected]>
Modifying us_pop_density.mapml (used in e.g. keyboardInteraction.html) results in the following:
<!--<title>US Population Density</title>-->
Should untitled layers be visible in the layer list?
The text was updated successfully, but these errors were encountered: