Skip to content
This repository was archived by the owner on May 25, 2025. It is now read-only.
This repository was archived by the owner on May 25, 2025. It is now read-only.

room claim is always set to * #331

@micolous

Description

@micolous

jitsi-openid always creates a JWT with a room claim set to *:

"*".to_string(),

The room is saved to the session, and is used in that same handler to construct a final URL to send to Jitsi Meet:

let mut url = state.config.jitsi_url.join(&session.room).unwrap();

Also, the room session attribute itself is set from an external input:

async fn room(
Path(room): Path<String>,
State(state): State<JitsiState>,
jar: CookieJar,
) -> impl IntoResponse {

This should reject setting it to *.

Properly scoping the JWT means you could also run the token_no_wildcard contrib plugin, so that Jitsi Meet any rejects token containing wildcards in the sub or room parameters, which could limit the scope of another security issue.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions