Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with Source.Clearance parameters #23

Open
dietmarw opened this issue Apr 20, 2018 · 0 comments
Open

Issues with Source.Clearance parameters #23

dietmarw opened this issue Apr 20, 2018 · 0 comments

Comments

@dietmarw
Copy link
Collaborator

When looking at Sources.Clearance there are several issues that could be improved:
image

  1. Order: SolutionFlow, Clearance, K and useSolutionFlowInput should be grouped together
  2. Dependencies: If K is needed to fulfil Clearance=K*solutionFlow then why can this not be calculated but needs to be provided
  3. Units: AmountOfSolutionIn1L really is a very complicated way to define the concentration. Why not simply use concentration and make use of the SIUnits.Conentration type. This is in mol/m3 but can simply be used *1000 in the code. That way the unit reflects what it is and the name is not as unfortunate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant