terraform test: Add --no-test

Author: def-

ci/plugins/mzcompose/hooks/pre-exit

@@ -149,13 +149,13 @@ ci_collapsed_heading ":docker: Purging all existing docker containers and volume
 docker ps --all --quiet | xargs --no-run-if-empty docker rm --force --volumes
 
 if [ "$BUILDKITE_STEP_KEY" = "terraform-aws" ]; then
-  run run aws-temporary --no-setup --no-run-testdrive-files || true
+  run run aws-temporary --no-setup --no-test || true
 elif [ "$BUILDKITE_STEP_KEY" = "terraform-aws-upgrade" ]; then
-  run run aws-upgrade --no-setup --no-run-testdrive-files || true
+  run run aws-upgrade --no-setup --no-test || true
 elif [ "$BUILDKITE_STEP_KEY" = "terraform-gcp" ]; then
-  run run gcp-temporary --no-setup --no-run-testdrive-files || true
+  run run gcp-temporary --no-setup --no-test || true
 elif [ "$BUILDKITE_STEP_KEY" = "terraform-azure" ]; then
-  run run azure-temporary --no-setup --no-run-testdrive-files || true
+  run run azure-temporary --no-setup --no-test || true
 fi
 rm -rf ~/.kube # Remove potential state from E2E Terraform tests
 

src/testdrive/src/action.rs

@@ -776,7 +776,7 @@ impl Run for PosCommand {
                         consistency::skip_consistency_checks(builtin, state)
                     }
                     "check-shard-tombstone" => {
-                        consistency::run_check_shard_tombstoned(builtin, state).await
+                        consistency::run_check_shard_tombstone(builtin, state).await
                     }
                     "fivetran-destination" => {
                         fivetran::run_destination_command(builtin, state).await

src/testdrive/src/action/consistency.rs

@@ -94,12 +94,12 @@ pub async fn run_consistency_checks(state: &State) -> Result<ControlFlow, anyhow
 /// Checks if a shard in Persist has been tombstoned.
 ///
 /// TODO(parkmycar): Run this as part of the consistency checks, instead of as a specific command.
-pub async fn run_check_shard_tombstoned(
+pub async fn run_check_shard_tombstone(
     mut cmd: BuiltinCommand,
     state: &State,
 ) -> Result<ControlFlow, anyhow::Error> {
     let shard_id = cmd.args.string("shard-id")?;
-    check_shard_tombstoned(state, &shard_id).await?;
+    check_shard_tombstone(state, &shard_id).await?;
     Ok(ControlFlow::Continue)
 }
 
@@ -237,8 +237,8 @@ async fn check_catalog_state(state: &State) -> Result<(), anyhow::Error> {
 }
 
 /// Checks if the provided `shard_id` is a tombstone, returning an error if it's not.
-async fn check_shard_tombstoned(state: &State, shard_id: &str) -> Result<(), anyhow::Error> {
-    println!("$ check-shard-tombstoned {shard_id}");
+async fn check_shard_tombstone(state: &State, shard_id: &str) -> Result<(), anyhow::Error> {
+    println!("$ check-shard-tombstone {shard_id}");
 
     let (Some(consensus_uri), Some(blob_uri)) =
         (&state.persist_consensus_url, &state.persist_blob_url)