Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for additional HTTP headers? #65

Open
ml-evs opened this issue Jun 8, 2021 · 1 comment
Open

Add support for additional HTTP headers? #65

ml-evs opened this issue Jun 8, 2021 · 1 comment
Labels
enhancement New feature or request question Further information is requested

Comments

@ml-evs
Copy link
Member

ml-evs commented Jun 8, 2021

As added in Materials-Consortia/optimade-python-tools#806.

Not sure if it makes sense to support this within the action (e.g. API keys via GitHub secrets), but happy to help out if we think it is worthwhile.

@ml-evs ml-evs added enhancement New feature or request question Further information is requested labels Jun 8, 2021
@CasperWA
Copy link
Member

CasperWA commented Jun 8, 2021

It seems like a good idea. To begin with it could be very raw input value, e.g., a complete JSON object as a value: headers: '{"X-Github-Header": "my header value"}'?

Later, one could add more user-friendly inputs that creates a specific header or set of headers. We'd need use cases for this though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants