Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduler uses classad functionality for matchmaking and scheduling #77

Draft
wants to merge 30 commits into
base: master
Choose a base branch
from

Conversation

eileen-kuehn
Copy link
Member

@eileen-kuehn eileen-kuehn commented Nov 29, 2019

This PR improves the current functionality of the scheduler by including functionality implemented in the classad package. This PR includes:

  • autoclustering based on quantize,
  • matchmaking based on classad evaluation,
  • documentation, and
  • unit tests.

Closes #67, #90, #82, #89, #88.

@codecov
Copy link

codecov bot commented Nov 29, 2019

Codecov Report

Merging #77 into master will decrease coverage by 6.86%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
- Coverage   59.89%   53.02%   -6.87%     
==========================================
  Files          15       15              
  Lines         763     1041     +278     
  Branches      111      159      +48     
==========================================
+ Hits          457      552      +95     
- Misses        282      464     +182     
- Partials       24       25       +1     
Impacted Files Coverage Δ
lapis/drone.py 73.07% <0.00%> (-1.44%) ⬇️
lapis/scheduler.py 41.62% <0.00%> (-18.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 989b805...37c38de. Read the comment docs.

@pep8speaks
Copy link

pep8speaks commented Dec 12, 2019

Hello @eileen-kuehn! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-02-24 16:15:56 UTC

@eileen-kuehn
Copy link
Member Author

Should be merged sooner than later! Old scheduler still needs to be added.

@lgtm-com
Copy link

lgtm-com bot commented Feb 24, 2020

This pull request introduces 1 alert when merging c802bee into 989b805 - view on LGTM.com

new alerts:

  • 1 for Unguarded next in generator

@lgtm-com
Copy link

lgtm-com bot commented Feb 24, 2020

This pull request introduces 1 alert when merging 4639893 into 989b805 - view on LGTM.com

new alerts:

  • 1 for Unguarded next in generator

@lgtm-com
Copy link

lgtm-com bot commented Feb 24, 2020

This pull request introduces 1 alert when merging 37c38de into 989b805 - view on LGTM.com

new alerts:

  • 1 for Unguarded next in generator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTCondor scheduler should rely on ClassAds
4 participants