Error in pi_get_dates(phishin_key, "1999-12-31") : Something went wrong

[MayaGans]

Getting the error:

Error in pi_get_dates(phishin_key, "1999-12-31") : Something went wrong
Status code: 404
Error in fetch(key) : 
  lazy-load database '/Library/Frameworks/R.framework/Versions/3.5/Resources/library/phishr/help/phishr.rdb' is corrupt

[levisc8]

pi_get_dates() is probably confusingly named, sorry about that! It's meant to retrieve all shows on a day of the year for all years (e.g. all new years shows for date = '12-31'. I think pi_get_shows(show = '1999-12-31') should do what that query is attempting.

I'm open to changing the name to more accurately reflect what the function is doing (e.g. pi_get_day_of_year). The current naming scheme is based on the entries in the API docs here, but we could definitely improve/clarify that scheme a bit.

[MayaGans]

I think I like pi_get_date more than pi_get_day_of_year, but maybe pi_all_shows_by_date is better? Your call, it makes sense now that you've described what it does and I plan to write vignettes for all our functions anyways.

That said, I think we might consider changing pi_get_shows to get_setlists?

[levisc8]

Those are both solid suggestions - I'll add them to my to-do list! If we can make the names more descriptive, then I don't see much reason to follow the API scheme. Shifting the naming seems like it'd only be confusing for those who've already interacted with it a lot (and I'm not sure there are many outside of the ReListen developers).