Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reliance on watchman #62

Open
batjko opened this issue Sep 20, 2017 · 5 comments
Open

Remove reliance on watchman #62

batjko opened this issue Sep 20, 2017 · 5 comments
Labels
feat-request
Milestone
v3

Comments

@batjko
Copy link

batjko commented Sep 20, 2017

In the interest of reducing annoyance of non-Mac users (especially windows ones), avoiding watchman would be a great boon for this package.

I am not sure what it should be replaced with, but ideally with something built into this package.

Many thanks!
@batjko batjko mentioned this issue Sep 20, 2017
Open
@Mayank1791989 Mayank1791989 added this to the v3 milestone Sep 20, 2017
@Mayank1791989
Copy link
Owner

This was already added in v3 (will be released soon).

@kumarharsh kumarharsh mentioned this issue Oct 18, 2017
Closed
@FezVrasta
Copy link

any updates on this?

@batjko
Copy link
Author

batjko commented Dec 31, 2017

This was already added in v3 (will be released soon).

What's the schedule for v3?

@danielkcz
Copy link

danielkcz commented Feb 22, 2018 •
edited
Loading

Just want to note here, that with Watchman Beta for Windows it's working just fine. I haven't run into any issues. Personally, I am against removing watchman. It's great tool conserving system resources into a single point instead of having numerous watchers over the same files. At least make it configurable so it's still possible to use Watchman.

@Mayank1791989
Copy link
Owner

@FredyC in v3 watchman is not removed. It will use NodeWatcher only if watchman is not present.

Mayank1791989 added a commit that referenced this issue Apr 18, 2018
@Mayank1791989
feat: v3 release
9756514 
BREAKING_CHANGE: structure of .gqlconfig file changed.

closes #3, closes #23, closes #28, closes #45, closes #52, closes #62, closes #99, closes #100, closes #115
Mayank1791989 added a commit that referenced this issue Apr 30, 2018
@Mayank1791989
feat: v3 release
f0a3ad7 
BREAKING_CHANGE: structure of .gqlconfig file changed.

closes #3, closes #23, closes #28, closes #45, closes #52, closes #62, closes #99, closes #100, closes #115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feat-request
Projects
None yet
Milestone
v3
Development

No branches or pull requests
4 participants
@danielkcz @Mayank1791989 @FezVrasta @batjko