-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace only replaces the first match #5
Comments
sculpt.replace(/regex/g, ...) works for me |
It does work when passing a |
Oh, I see. The flags param in String#replace is actually not in v8 and according to MDN it's deprecated (presumably in Firefox). |
I suppose it is more of a convenience argument, but I just sent a pull request which will build the RegExp for you if you pass a string and flag. |
As a side note, it looks like there is an issue with you saucelabs credentials causing builds to break. |
Replace does not allow us to pass in a global flag, so it will only replace the first string matched.
The text was updated successfully, but these errors were encountered: