Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config - api_url_base #86

Open
pnadolny13 opened this issue Feb 9, 2022 · 1 comment
Open

Config - api_url_base #86

pnadolny13 opened this issue Feb 9, 2022 · 1 comment
Assignees
@ericboucher @aaronsteers

Comments

@pnadolny13
Copy link
Contributor

I see api_url_base is retrieved from the config in the code here but its not listed in the config options in the tap. I'm not positive but I think it would be ignored right now if it was set in the config.json, is that right?

Is this purposeful? If not I can create a PR to get it added to the config!
@ericboucher
Copy link
Contributor

@pnadolny13 definitely worth it! Feel free to tag me as a reviewer if you end up opening a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericboucher ericboucher

@aaronsteers aaronsteers

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ericboucher @aaronsteers @pnadolny13