Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSH Tunnel configuration is required even when disabled #19

Open
BTheunissen opened this issue Nov 7, 2023 · 2 comments
Open

SSH Tunnel configuration is required even when disabled #19

BTheunissen opened this issue Nov 7, 2023 · 2 comments

Comments

@BTheunissen
Copy link

https://github.com/MeltanoLabs/tap-mysql/blob/main/tap_mysql/tap.py#L113

Was integrating the tap today and had some issues where the config for SSH tunnel is marked as required even when the feature is not in use, to get around I just added stub values in my base meltano.yml config for the extractor, but would be better to validate these fields only when SSH tunnel is enabled.

@BamboOSZ
Copy link
Contributor

I just hit this same problem. I receive a rather generic error about the host not being configured (even tho it is) once the SSL config is populated with any values, it seems to be working fine.

@visch
Copy link
Member

visch commented Mar 26, 2024

If you don't have anything in the ssh_tunnel you should be good to go.

But good points, next steps look like

  1. If ssh tunnel isn't configured properly it seems like the error incorrectly states "host not configured" look into this
  2. If ssh tunnel does exist and enable is false don't require anything other config values to be set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants