Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incremental stream unexpectedly emitting ACTIVATE_VERSION messages #56

Open
edgarrmondragon opened this issue Mar 8, 2024 · 0 comments
Open

Incremental stream unexpectedly emitting ACTIVATE_VERSION messages #56

edgarrmondragon opened this issue Mar 8, 2024 · 0 comments

Comments

@edgarrmondragon
Copy link
Member

Looking at the code in

tap-salesforce/tap_salesforce/__init__.py

Line 476 in 64ca3f9

if replication_key or bookmark_is_empty:

it seems that it should be

-         if replication_key or bookmark_is_empty:
+         if not replication_key or bookmark_is_empty:
yulherman added a commit to yulherman/tap-salesforce that referenced this issue Mar 14, 2024
@yulherman
Incremental stream unexpectedly emitting ACTIVATE_VERSION messages. I…
0e10079 
…ssue - MeltanoLabs#56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
MeltanoLabs Overview
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@edgarrmondragon