fix: fix reporting message (#760)

- Missing `len` when displaying number of success spans
- Replace `click.echo("")` by an explicit `os.linesep`

Author: Greesb

mergify_cli/ci/cli.py

@@ -1,3 +1,4 @@
+import os
 import sys
 
 import click
@@ -243,11 +244,13 @@ async def _process_junit_files(  # noqa: PLR0913
             if span.status.status_code == opentelemetry.trace.StatusCode.ERROR
         ],
     )
-    nb_success_spans = [
-        span
-        for span in tests_cases
-        if span.status.status_code == opentelemetry.trace.StatusCode.OK
-    ]
+    nb_success_spans = len(
+        [
+            span
+            for span in tests_cases
+            if span.status.status_code == opentelemetry.trace.StatusCode.OK
+        ],
+    )
     click.echo(
         f"🧪 Parsed tests: {len(tests_cases)} (✅ passed: {nb_success_spans} | ❌ failed: {nb_failing_spans})",
     )
@@ -295,14 +298,13 @@ async def _process_junit_files(  # noqa: PLR0913
             err=True,
         )
 
-    click.echo("")
     if quarantine_exit_error_code == 0:
-        click.echo("🎉 Verdict")
+        click.echo(f"{os.linesep}🎉 Verdict")
         click.echo(
             f"• Status: ✅ OK — all {nb_failing_spans} failures are quarantined (ignored for CI status)",
         )
     else:
-        click.echo("❌ Verdict")
+        click.echo(f"{os.linesep}❌ Verdict")
         click.echo(
             f"• Status: 🔴 FAIL — {failing_tests_not_quarantined_count} unquarantined failures detected ({nb_failing_spans - failing_tests_not_quarantined_count} quarantined)",
         )

mergify_cli/ci/quarantine.py

@@ -1,4 +1,5 @@
 import dataclasses
+import os
 import typing
 
 import click
@@ -37,8 +38,7 @@ async def check_and_update_failing_spans(
     Returns the number of failing tests that are not quarantined.
     """
 
-    click.echo("")
-    click.echo("🛡️ Quarantine")
+    click.echo(f"{os.linesep}🛡️ Quarantine")
 
     failing_spans = [
         span

mergify_cli/tests/ci/test_cli.py

@@ -4,6 +4,7 @@
 import anys
 import click
 from click import testing
+from opentelemetry.sdk.trace import id_generator
 import pytest
 
 from mergify_cli.ci import cli as cli_junit_upload
@@ -310,3 +311,46 @@ def test_junit_file_not_found_error_message() -> None:
         assert (
             "check if your test execution step completed successfully" in result.output
         )
+
+
+async def test_process_junit_file_reporting(
+    capsys: pytest.CaptureFixture[str],
+) -> None:
+    with (
+        mock.patch.object(
+            quarantine,
+            "check_and_update_failing_spans",
+            return_value=0,
+        ),
+        mock.patch.object(upload, "upload"),
+        mock.patch.object(
+            id_generator.RandomIdGenerator,
+            "generate_span_id",
+            return_value=12345678910,
+        ),
+        pytest.raises(SystemExit),
+    ):
+        await cli_junit_upload._process_junit_files(
+            api_url="https://api.mergify.com",
+            token="foobar",  # noqa: S106
+            repository="foo/bar",
+            test_framework=None,
+            test_language=None,
+            tests_target_branch="main",
+            files=(str(REPORT_XML),),
+        )
+
+    captured = capsys.readouterr()
+    assert (
+        captured.out
+        == """🚀 CI Insights · Upload JUnit
+────────────────────────────
+📂 Discovered reports: 1
+🛠️ MERGIFY_TEST_RUN_ID=00000002dfdc1c3e
+🧪 Parsed tests: 2 (✅ passed: 1 | ❌ failed: 1)
+
+🎉 Verdict
+• Status: ✅ OK — all 1 failures are quarantined (ignored for CI status)
+• Exit code: 0
+"""
+    )