Skip to content

Commit 926a607

Browse files
authored
chore: use os.linesep in quarantine reporting instead of raw \n (#730)
1 parent 71eca57 commit 926a607

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

mergify_cli/ci/cli.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import dataclasses
2+
import os
23
import sys
34

45
import click
@@ -276,9 +277,9 @@ async def _check_failing_spans_with_quarantine(
276277
tests_target_branch: str,
277278
failing_spans_names: list[str],
278279
) -> None:
279-
fspans_str = "\n".join(failing_spans_names)
280+
fspans_str = os.linesep.join(failing_spans_names)
280281
click.echo(
281-
f"Checking the following failing tests for quarantine:\n{fspans_str}",
282+
f"Checking the following failing tests for quarantine:{os.linesep}{fspans_str}",
282283
err=False,
283284
)
284285

@@ -305,23 +306,23 @@ async def _check_failing_spans_with_quarantine(
305306

306307
resp_json = response.json()
307308
if resp_json["quarantined_tests_names"]:
308-
quarantined_test_names_str = "\n".join(
309+
quarantined_test_names_str = os.linesep.join(
309310
resp_json["quarantined_tests_names"],
310311
)
311312
click.echo(
312-
f"The following failing tests are quarantined and will be ignored:\n{quarantined_test_names_str}",
313+
f"The following failing tests are quarantined and will be ignored:{os.linesep}{quarantined_test_names_str}",
313314
err=False,
314315
)
315316

316317
if not resp_json["non_quarantined_tests_names"]:
317318
return
318319

319-
non_quarantined_test_names_str = "\n".join(
320+
non_quarantined_test_names_str = os.linesep.join(
320321
resp_json["non_quarantined_tests_names"],
321322
)
322323
click.echo(
323324
click.style(
324-
f"The following failing tests are not quarantined:\n{non_quarantined_test_names_str}",
325+
f"{os.linesep}The following failing tests are not quarantined:{os.linesep}{non_quarantined_test_names_str}",
325326
fg="red",
326327
),
327328
)

0 commit comments

Comments
 (0)