fix(ci): do not fail on upload failure (#683)

This makes sure the CI does not break if upload cannot be done.

Fixes MRGFY-5182

Author: jd

mergify_cli/ci/cli.py

@@ -58,11 +58,17 @@ async def junit_upload(  # noqa: PLR0913, PLR0917
     test_language: str | None,
     files: tuple[str, ...],
 ) -> None:
-    await upload.upload(
-        api_url=api_url,
-        token=token,
-        repository=repository,
-        test_framework=test_framework,
-        test_language=test_language,
-        files=files,
-    )
+    try:
+        await upload.upload(
+            api_url=api_url,
+            token=token,
+            repository=repository,
+            test_framework=test_framework,
+            test_language=test_language,
+            files=files,
+        )
+    except Exception as e:  # noqa: BLE001
+        click.echo(
+            click.style(f"Error uploading JUnit XML reports: {e}", fg="red"),
+            err=True,
+        )

mergify_cli/tests/ci/test_cli.py

@@ -65,3 +65,41 @@ def test_cli(env: dict[str, str], monkeypatch: pytest.MonkeyPatch) -> None:
         "test_language": None,
         "files": (str(REPORT_XML),),
     }
+
+
+def test_upload_error(monkeypatch: pytest.MonkeyPatch) -> None:
+    for key, value in {
+        "GITHUB_EVENT_NAME": "push",
+        "GITHUB_ACTIONS": "true",
+        "MERGIFY_API_URL": "https://api.mergify.com",
+        "MERGIFY_TOKEN": "abc",
+        "GITHUB_REPOSITORY": "user/repo",
+        "GITHUB_SHA": "3af96aa24f1d32fcfbb7067793cacc6dc0c6b199",
+        "GITHUB_WORKFLOW": "JOB",
+    }.items():
+        monkeypatch.setenv(key, value)
+
+    runner = testing.CliRunner()
+
+    with mock.patch.object(
+        upload,
+        "upload",
+        mock.AsyncMock(),
+    ) as mocked_upload:
+        mocked_upload.side_effect = Exception("Upload failed")
+        result = runner.invoke(
+            cli_junit_upload.junit_upload,
+            [str(REPORT_XML)],
+        )
+    assert result.exit_code == 0, (result.stdout, result.stderr)
+    assert result.stderr == "Error uploading JUnit XML reports: Upload failed\n"
+    assert not result.stdout
+    assert mocked_upload.call_count == 1
+    assert mocked_upload.call_args.kwargs == {
+        "api_url": "https://api.mergify.com",
+        "token": "abc",
+        "repository": "user/repo",
+        "test_framework": None,
+        "test_language": None,
+        "files": (str(REPORT_XML),),
+    }