test(ci-insights): Improve test for unhealthy tests detection (#281)

The goal of this change is to improve the test to make sure the flaky
detection is not breaking CI of our users by asserting the exit code of
the pytest process.

References: INC-402

Author: remyduthu

tests/test_ci_insights.py

@@ -252,7 +252,7 @@ def test_bar():
             global execution_count
             execution_count += 1
 
-            if execution_count == 1:
+            if execution_count == 2:
                 pytest.fail("I'm flaky!")
 
         def test_baz():
@@ -266,10 +266,12 @@ def test_quux():
         """
     )
 
+    # The goal is to make sure the failed rerun of the flaky test does not
+    # impact the results to avoid failing the CI of our users.
+    assert result.ret == 0
     result.assert_outcomes(
-        failed=1,  # Only the first execution of the flaky test.
-        passed=3,  # Do not log the reruns so the CI doesn't fail. The goal is to send data to Mergify, not lock the CI of our users.
-        skipped=1,  # The skipped test is tested only once because skipped tests are excluded from the flaky detection.
+        passed=4,  # Initial run of each test.
+        skipped=1,
     )
 
     assert re.search(