Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update page generator to support linking to assets correctly #88

Open
Montoya opened this issue Feb 7, 2023 · 2 comments
Open

Update page generator to support linking to assets correctly #88

Montoya opened this issue Feb 7, 2023 · 2 comments
Assignees
Labels
bug Something isn't working tools This issue concerns the tooling used in this repository

Comments

@Montoya
Copy link
Contributor

Montoya commented Feb 7, 2023

See this comment:

For example this link - https://metamask.github.io/SIPs/assets/sip-9/example-snap/, it exists in the repository but 404s on the page, we would either have to update the SIP to point to specific files instead of directories or update the page generator

This issue should be resolved so we can use the website for canonical links to SIPs.

@ritave ritave added bug Something isn't working tools This issue concerns the tooling used in this repository labels Feb 7, 2023
@FrederikBolding
Copy link
Member

@ritave Static files are available on the website, e.g. https://metamask.github.io/SIPs/assets/sip-9/example-snap/snap.manifest.json - Is the problem that we want to show a directory structure for dirs?

@ritave
Copy link
Contributor

ritave commented May 15, 2023

@FrederikBolding yes, it's fine if it just redirects to GitHub directory view instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tools This issue concerns the tooling used in this repository
Projects
None yet
Development

No branches or pull requests

3 participants