perf(keyring-eth-hd): store computed account address

[danroc]

Store the computed account address together with the HD node. This should prevent the need to recompute the address when listing accounts or finding an account by its address.

[Copilot]

Pull Request Overview

This PR optimizes the HD keyring by pre-computing and storing Ethereum account addresses alongside HD keys to avoid repeated address calculations during account operations.

• Store computed addresses in a new WalletData structure containing both HDKey and address
• Eliminate redundant address computations in getAccounts(), removeAccount(), and #getWalletForAccount()
• Simplify address lookups by using pre-stored values instead of deriving from public keys

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[ccharly]

LGTM! I'll wait for @mikesposito review too.

[danroc]

@metamaskbot publish-preview

[github-actions]

Preview builds have been published. See these instructions (from the core monorepo) for more information about preview builds.

Expand for full list of packages and versions.

{
  "@metamask-previews/account-api": "0.12.0-ca7f2af",
  "@metamask-previews/keyring-api": "21.0.0-ca7f2af",
  "@metamask-previews/eth-hd-keyring": "12.1.0-ca7f2af",
  "@metamask-previews/eth-ledger-bridge-keyring": "11.1.2-ca7f2af",
  "@metamask-previews/eth-qr-keyring": "1.1.0-ca7f2af",
  "@metamask-previews/eth-simple-keyring": "10.0.0-ca7f2af",
  "@metamask-previews/eth-trezor-keyring": "9.0.0-ca7f2af",
  "@metamask-previews/keyring-internal-api": "9.0.0-ca7f2af",
  "@metamask-previews/keyring-internal-snap-client": "7.1.0-ca7f2af",
  "@metamask-previews/eth-snap-keyring": "17.1.0-ca7f2af",
  "@metamask-previews/keyring-snap-client": "8.0.0-ca7f2af",
  "@metamask-previews/keyring-snap-sdk": "7.0.0-ca7f2af",
  "@metamask-previews/keyring-utils": "3.1.0-ca7f2af"
}

[mikesposito]

Great find, LGTM!