Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing controller guidelines #5335

Open
mcmire opened this issue Feb 14, 2025 · 0 comments
Open

Add missing controller guidelines #5335

mcmire opened this issue Feb 14, 2025 · 0 comments
Labels
team-wallet-framework

Comments

@mcmire
Copy link
Contributor

mcmire commented Feb 14, 2025

  • State should be coherent at all times. If properties are intended to be used in conjunction with each other they should be consistent, and we should have runtime validation to ensure that this is always the case.
  • Use withController or setupController pattern to set up controllers in tests.
  • Don't mock the messenger in tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mcmire