feat: add MegaETH Testnet to network-controller
#5527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
stanleyyconsensys
changed the title
MegaETH Testnet to network controller
stanleyyconsensys
changed the title
MegaETH Testnet to network controllerMegaETH Testnet to network-controller
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
stanleyyconsensys
force-pushed
the
feat/add-megaeth-testnet-to-network-controller
branch
from
57dc107 to
38ce0ec
Compare
mcmire
reviewed
Mar 27, 2025
mcmire
reviewed
Mar 27, 2025
salimtb
approved these changes
Mar 27, 2025
OGPoyraz
approved these changes
Mar 27, 2025
- fix mock network hardcoded mock path when RPC has endpoint with '/rpc' - fix test result on token detection when megaETH network added as default
stanleyyconsensys
force-pushed
the
feat/add-megaeth-testnet-to-network-controller
branch
from
39d35a4 to
80be045
Compare
wantedsystem
approved these changes
Mar 27, 2025
stanleyyconsensys
deleted the
feat/add-megaeth-testnet-to-network-controller
branch
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Further to Previous PR: #5495
We are adding MegaETH Testnet as default network on
Network Controllerdefault state -networkConfigurationsByChainIdwith the constants and type from the latestcontroller-utilsIn additional, a new constructor option
addtionalDefaultNetworkshas introduced inNetworkControllertoprevent client push the new network unintentionally
(such as bump up the network controller without support on the client side)
Changes:
Add Constructor Option
addtionalDefaultNetworksto specify the additional default networks to be included, which allows backward compatible and only include the Network if it has ready on client side (by developer specify)Refactor the logic to separate the construction of default network configurations to methods
getDefaultInfuraNetworkConfigurationsByChainIdandgetDefaultCustomNetworkConfigurationsByChainIdFix
mock-networknot support a use case when the RPC endpoint come with a path segment, e.g: 'https://carrot.megaeth.com/rpc'Add
MegaETH TestnetChainId into constantsCHAIN_IDSfromtransaction-controllerNote :
For everyone interested in testing this version in MM mobile you can use this branch to do so : https://github.com/MetaMask/metamask-mobile/tree/feat/add-megaeth-testnet
References
Changelog
@metamask/network-controlleraddtionalDefaultNetworksto specify the additional networks to be included as the default network.@metamask/transaction-controllerMegaETH TestnetChainId into constantsCHAIN_IDSChecklist