## Explanation Removes various redundant and easily resolved exceptions to our lint rules in `eth-block-tracker` and `eth-json-rpc-middleware`. Migrating the types of the latter from `interface` to `type` is extremely unlikely to be noticed by consumers due to the nature and usage of the types in question. There we do not consider that change breaking. ## References - Ref: #6879 - Ref: #6880 ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs), highlighting breaking changes as necessary - [x] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes  --- > [!NOTE] > Replaces interfaces with type aliases in eth-json-rpc-middleware, adds/tightens per-package ESLint rules (incl. jsdoc) for eth-block-tracker and middleware, updates warning thresholds, and consolidates Jest global type declarations. > > - **Linting/Config**: > - **ESLint overrides**: Add per-package rules for `packages/eth-block-tracker/**/*.ts` and tighten `packages/eth-json-rpc-middleware/**/*.ts` (e.g., enable `jsdoc/require-jsdoc`, warn on naming, nullish coalescing, unbound-method, no-restricted-syntax, etc.). > - **Warning thresholds**: Update `eslint-warning-thresholds.json` to reflect new rules and packages (shift from explicit-return-type to jsdoc-related warnings, add rule counts for eth-block-tracker and middleware files). > - **Types (eth-json-rpc-middleware)**: > - Migrate multiple `interface` declarations to `type` aliases in `src/block-cache.ts`, `src/block-ref(-rewrite).ts`, `src/block-tracker-inspector.ts`, `src/inflight-cache.ts`, `src/retryOnEmpty.ts`, `src/types.ts`, `src/wallet.ts`, and related tests/utilities. > - Update `CHANGELOG.md` to note the interface-to-type migration. > - **Tests/Types**: > - Remove `packages/eth-json-rpc-middleware/types/global.d.ts` and consolidate Jest matcher typings into root `types/global.d.ts` (adjust comments and ESLint disables). > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 70915a3. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup>

Uh oh!

[eth-block-tracker] Resolve lint config exceptions #6879

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions