Skip to content

fix: swap tx status events #5993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 37 commits into from
Jun 20, 2025
Merged

fix: swap tx status events #5993

merged 37 commits into from
Jun 20, 2025

Conversation

micaelae
Copy link
Member

@micaelae micaelae commented Jun 17, 2025

Explanation

This fixes the following Unified SwapBridge events to match the Unified SwapBridge spec

  • Completed: removes multichain tx controller subscription and emits the event based on the tx submission status instead
  • Submitted
    • set swap type for evm txs when applicable. this is currently hardcoded to bridge so swaps don't get displayed correctly on the activity list
    • emit this event when submitTx is called, regardless of confirmation status
  • Failed
    • emit this when an error is thrown during solana tx submission
    • use activeQuote to populate quote properties if tx fails before being confirmed on chain
  • Negates the value of the can_submit property

References

Fixes https://consensyssoftware.atlassian.net/browse/MMS-2608

Changelog

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Sorry, something went wrong.

@micaelae micaelae requested a review from a team as a code owner June 17, 2025 23:47
@micaelae micaelae requested a review from a team as a code owner June 18, 2025 00:40
@micaelae micaelae changed the title fix: EVM swap tx metrics fix: swap tx status events Jun 18, 2025
@micaelae micaelae merged commit e47e668 into main Jun 20, 2025
214 checks passed
@micaelae micaelae deleted the mms2608-fix-swap-metrics branch June 20, 2025 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants