Use Map to maintain delegator environment overrides #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffsmale90
force-pushed
the
fix/overridesMap
branch
from
595af0e to
d753e21
Compare
MoMannn
requested changes
Jul 14, 2025
| ): DeleGatorEnvironment { | ||
| const overrideKey = getContractOverrideKey(chainId, version); | ||
|
|
||
| if (contractOverrideMap.has(overrideKey)) { |
There was a problem hiding this comment.
Is the has check necessary? get will return undefined if there is no key found so the if (overridenContracts) should take care of the check.
There was a problem hiding this comment.
Yeah, good call! I've fixed this :)
MoMannn
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Previously the delegation overrides were maintained on a simple object, mapping version, and chainId to the DeleGatorEnvironment. With this change, a
Map<string, DeleGatorEnvironment>is used to maintain this information.🔄 What Changed?
When overriding a delegator deployment, a key is generated from the version and chainId, which is used in the key of a
Maptosetthe value to the overiden environment. When fetching the same util is used to generate the key, if the key exists in the map, then the value is returned.🚀 Why?
This resolves the following vulnerability, where malicious input could potentially pollute the global object prototype https://github.com/MetaMask/delegation-toolkit/security/code-scanning/1
🧪 How to Test?
No functional changes - overriding deployed environments is covered in unit tests.
List any breaking changes:
📋 Checklist
Check off completed items:
🔗 Related Issues
Link to related issues:
Closes # https://github.com/MetaMask/delegation-toolkit/security/code-scanning/1