New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

signTypedData: empty arrays of structs should be all zero bytes #248

Closed

danfinlay opened this issue Apr 22, 2022 · 2 comments

Labels

Milestone

signTypedData_v5

Contributor

danfinlay commented Apr 22, 2022

To match solidity.

You can see a sample change that achieves this here.

danfinlay added the enhancement label

danfinlay added this to the signTypedData_v5 milestone

Contributor Author

danfinlay commented Apr 22, 2022

This may be reflected in #134

Contributor Author

danfinlay commented Apr 23, 2022

My mistake, it should be the hash of zero bytes, which is what #134 already does.

danfinlay closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment