Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signTypedData: uint and int fields should be forbidden #55

Open
cag opened this issue Jun 18, 2019 · 1 comment
Open

signTypedData: uint and int fields should be forbidden #55

cag opened this issue Jun 18, 2019 · 1 comment
Labels

Comments

@cag
Copy link
Contributor

cag commented Jun 18, 2019

Right now, signTypedData will accept uint and int, but EIP 712 states that only integer types with their size are allowed.

Trying to use these should error, telling users that uint256 and int256 should be used instead when encountering these types.

@Gudahtt Gudahtt added the bug label Jul 15, 2021
@Gudahtt Gudahtt added this to the v4 milestone Jul 20, 2021
@Gudahtt
Copy link
Member

Gudahtt commented Jul 20, 2021

Thanks for the report! I agree, but now that signTypedData has been out in the wild for a while, making this change might break dapps.

We might bundle this with a fix for another spec incompatibility that was reported, and ship it as signTypedData_v5

@Gudahtt Gudahtt removed this from the v4 milestone Jul 20, 2021
@Gudahtt Gudahtt added this to the signTypedData_v5 milestone Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants