Skip to content

[DSRN] Add Font Family Default, Hero, and Accent to Text component #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
2 of 9 tasks
brianacnguyen opened this issue Mar 27, 2025 · 0 comments
Open
2 of 9 tasks

[DSRN] Add Font Family Default, Hero, and Accent to Text component #521

brianacnguyen opened this issue Mar 27, 2025 · 0 comments
Assignees
@brianacnguyen
Labels
team-design-system

Comments

@brianacnguyen
Copy link
Contributor

What is this about?

Add FontFamily prop to Text with the following options:

  • Default - CentraNo1
  • Accent - MMSans
  • Hero - MMPoly

Ensure these changes are applied across the application and verify consistency in design components.

References

  • N/A (Provide any relevant design documentation or links if available)

Scenario

No response

Design

No response

Technical Details

Add FontFamily prop to Text with the following options:

  • Default - CentraNo1
  • Accent - MMSans
  • Hero - MMPoly

Threat Modeling Framework

No response

Acceptance Criteria

  • Updated typography values are reflected in the codebase.
  • Design consistency is maintained across UI elements.
  • No regressions in text alignment, readability, or layout structure.

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response
@brianacnguyen brianacnguyen self-assigned this Mar 27, 2025
@brianacnguyen brianacnguyen changed the title Copy of [DSR] Add Font Family Default, Hero, and Accent to Text component [DSRN] Add Font Family Default, Hero, and Accent to Text component Mar 27, 2025
@brianacnguyen brianacnguyen mentioned this issue Mar 31, 2025
Merged
7 tasks
georgewrmarshall pushed a commit that referenced this issue Mar 31, 2025
@brianacnguyen
Updated and added new font families to monorepo (#533)
44032a9 
**!!BREAKING CHANGES!!**

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
- This PR updated the font-family in all packages to have
`default`/`accent`/`hero` font families
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes: #520, #521 

## **Manual testing steps**

1. Run `yarn storybook` or `yarn storybook:ios` from root
2. Go to `React Components` or `Components` > Text
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**


https://github.com/user-attachments/assets/e2126101-a536-498e-bae1-932328fe1cf9


https://github.com/user-attachments/assets/4ee52c18-b5ed-4554-9f79-b59eac61f1b7



<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs)
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brianacnguyen brianacnguyen

Labels
team-design-system
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brianacnguyen