Skip to content

Commit d0e903d

Browse files
fix: bump @metamask/keyring-controller to ^19.2.2 (#31293)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Bumping `@metamask/keyring-controller` to 19.2.2 ```markdown ## [19.2.2] ### Fixed - Fixed duplication of unsupported keyrings ([#5535](MetaMask/core#5535)) - Enforce keyrings metadata alignment when unlocking existing vault ([#5535](MetaMask/core#5535)) - Fixed frozen object mutation attempt when updating metadata ([#5535](MetaMask/core#5535)) ## [19.2.1] ### Changed - Bump `@metamask/keyring-api"` from `^17.0.0` to `^17.2.0` ([#5366](MetaMask/core#5366)) - Bump `@metamask/keyring-internal-api` from `^4.0.1` to `^4.0.3` ([#5356](MetaMask/core#5356)), ([#5366](MetaMask/core#5366)) ### Fixed - Ensure authorization contract address is provided ([#5353](MetaMask/core#5353)) ``` [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/31293?quickstart=1) ## **Related issues** Related: #31200 ## **Manual testing steps** 1. Start with an installation from before we introduced keyringsMetadata, proceed past onboarding so that you have a vault setup (e.g. v12.12.0) 2. Upgrade to this branch 3. Start the extension (without logging in) 4. Leave the window open a while to give it time to initialize all controllers 5. Reload the extension before unlocking 6. Try to unlock the wallet ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: MetaMask Bot <[email protected]>
1 parent 38a32b8 commit d0e903d

File tree

6 files changed

+10
-6
lines changed

6 files changed

+10
-6
lines changed

lavamoat/browserify/beta/policy.json

+1
Original file line numberDiff line numberDiff line change
@@ -1453,6 +1453,7 @@
14531453
},
14541454
"@metamask/keyring-controller": {
14551455
"globals": {
1456+
"console.error": true,
14561457
"console.log": true
14571458
},
14581459
"packages": {

lavamoat/browserify/flask/policy.json

+1
Original file line numberDiff line numberDiff line change
@@ -1453,6 +1453,7 @@
14531453
},
14541454
"@metamask/keyring-controller": {
14551455
"globals": {
1456+
"console.error": true,
14561457
"console.log": true
14571458
},
14581459
"packages": {

lavamoat/browserify/main/policy.json

+1
Original file line numberDiff line numberDiff line change
@@ -1453,6 +1453,7 @@
14531453
},
14541454
"@metamask/keyring-controller": {
14551455
"globals": {
1456+
"console.error": true,
14561457
"console.log": true
14571458
},
14581459
"packages": {

lavamoat/browserify/mmi/policy.json

+1
Original file line numberDiff line numberDiff line change
@@ -1545,6 +1545,7 @@
15451545
},
15461546
"@metamask/keyring-controller": {
15471547
"globals": {
1548+
"console.error": true,
15481549
"console.log": true
15491550
},
15501551
"packages": {

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,7 @@
282282
"@metamask/json-rpc-engine": "^10.0.0",
283283
"@metamask/json-rpc-middleware-stream": "^8.0.4",
284284
"@metamask/keyring-api": "^17.2.1",
285-
"@metamask/keyring-controller": "^19.2.0",
285+
"@metamask/keyring-controller": "^19.2.2",
286286
"@metamask/keyring-internal-api": "^4.0.3",
287287
"@metamask/keyring-snap-client": "^4.0.1",
288288
"@metamask/logging-controller": "^6.0.4",

yarn.lock

+5-5
Original file line numberDiff line numberDiff line change
@@ -5565,9 +5565,9 @@ __metadata:
55655565
languageName: node
55665566
linkType: hard
55675567

5568-
"@metamask/keyring-controller@npm:^19.2.0, @metamask/keyring-controller@npm:^19.2.1":
5569-
version: 19.2.1
5570-
resolution: "@metamask/keyring-controller@npm:19.2.1"
5568+
"@metamask/keyring-controller@npm:^19.2.1, @metamask/keyring-controller@npm:^19.2.2":
5569+
version: 19.2.2
5570+
resolution: "@metamask/keyring-controller@npm:19.2.2"
55715571
dependencies:
55725572
"@ethereumjs/util": "npm:^8.1.0"
55735573
"@keystonehq/metamask-airgapped-keyring": "npm:^0.14.1"
@@ -5583,7 +5583,7 @@ __metadata:
55835583
ethereumjs-wallet: "npm:^1.0.1"
55845584
immer: "npm:^9.0.6"
55855585
ulid: "npm:^2.3.0"
5586-
checksum: 10/e9715a0743689c54843fd68f58ba1a577fd2f1a3ff104bd2e3d592c9246c56098f90288fab6c0d511e4a7115d2e9b835862885f37c3495aa2dd12db7df673326
5586+
checksum: 10/84797b7f22f86c9f01325dd3f73961033724ab348d5e5993e0b150c9508bf8c48b80cfa28dc5499878bad86c95473a9cd27aef059ab6eb841113632f6c85090d
55875587
languageName: node
55885588
linkType: hard
55895589

@@ -27266,7 +27266,7 @@ __metadata:
2726627266
"@metamask/json-rpc-engine": "npm:^10.0.0"
2726727267
"@metamask/json-rpc-middleware-stream": "npm:^8.0.4"
2726827268
"@metamask/keyring-api": "npm:^17.2.1"
27269-
"@metamask/keyring-controller": "npm:^19.2.0"
27269+
"@metamask/keyring-controller": "npm:^19.2.2"
2727027270
"@metamask/keyring-internal-api": "npm:^4.0.3"
2727127271
"@metamask/keyring-snap-client": "npm:^4.0.1"
2727227272
"@metamask/logging-controller": "npm:^6.0.4"

0 commit comments

Comments
 (0)