-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Open
Labels
Sev2-normalNormal severity; minor loss of service or inconvenience.Normal severity; minor loss of service or inconvenience.needs-triageIssue needs to be triagedIssue needs to be triagedregression-RC-13.0.0Regression bug that was found in release candidate (RC) for release 13.0.0Regression bug that was found in release candidate (RC) for release 13.0.0team-confirmationsPush issues to confirmations teamPush issues to confirmations teamtype-bugSomething isn't workingSomething isn't working
Description
Describe the bug
When doing a swap in a dApp, when we have to approve the spending cap for a token, it appears twice
Expected behavior
The message "you approve" for the spending cap should appear once
Screenshots/Recordings
https://www.loom.com/share/3a5dbea04a364742845f3ca4477ffd84?sid=09c0dbc4-5f33-443a-a203-ff7fc54f3886
Steps to reproduce
- Go to a dApp (Uniswap for example)
- Swap a token to another one, the source one should not be approved (you can use https://revoke.cash for this)
Error messages or log output
Detection stage
During release testing
Version
13.0.0
Build type
None
Browser
Chrome
Operating system
MacOS
Hardware wallet
No response
Additional context
If you edit different values in both fields, the approval is done with the sum of those 2 values.
Severity
No response
Metadata
Metadata
Assignees
Labels
Sev2-normalNormal severity; minor loss of service or inconvenience.Normal severity; minor loss of service or inconvenience.needs-triageIssue needs to be triagedIssue needs to be triagedregression-RC-13.0.0Regression bug that was found in release candidate (RC) for release 13.0.0Regression bug that was found in release candidate (RC) for release 13.0.0team-confirmationsPush issues to confirmations teamPush issues to confirmations teamtype-bugSomething isn't workingSomething isn't working
Type
Projects
Status
To be triaged