-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Open
Labels
good first issueGood for newcomersGood for newcomersteam-design-systemAll issues relating to design system in ExtensionAll issues relating to design system in Extension
Description
Description
Currently, the extension is using an outdated TextField
component, which needs to be replaced with the new TextField
component.
This is a massive undertaking by itself and creating a single PR would be too large. Smaller PRs can be submitted against this issue to ensure easier review and gradual improvements. It also means that this issue will not be assigned to a single engineer
Technical Details
- Replace instances of
TextField
component (ui/components/ui/text-field/text-field.component.js
) withTextField
component (ui/components/component-library/text-field/text-field.js
) - Component APIs are slightly different so ensure all props have been migrated appropriately
- Ensure there are no visual or functional regressions
Acceptance Criteria
- Instances of
TextField
component are completely replaced with the newTextField
component - The component APIs are updated to reflect the changes in the new `TextField`` component and there is no functional changes or visual regression
- Each Pull Request (PR) should include no more than 3 files
- The code changes should pass Jest tests, linting, and Storybook without any errors.
- The PR must include before and after screenshots of the UI to ensure there are no visual regressions.
If the acceptance criteria is not met, PRs may be closed.
Difficulty: Intermediate
Good first issue for: External contributors who are familiar with running the extension locally, have knowledge of React, component props, Jest tests, linting, and Storybook, and want to contribute to improving the cohesiveness of UI in the extension
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomersteam-design-systemAll issues relating to design system in ExtensionAll issues relating to design system in Extension