Skip to content

Commit 827ea02

Browse files
authored
fix: Add :app: prefix to specify exact Android task to build (#16213)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Some individuals were experiencing a build failure when running the build command for e2e local builds. This PR applies more specific task names to what is actually run so that it avoids running other flavors other than what is specified ## **Related issues** Fixes: ## **Manual testing steps** - `yarn test:e2e:android:debug:build` - E2E local build should build successfully ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> <img width="782" alt="Screenshot 2025-06-09 at 3 16 19 PM" src="https://github.com/user-attachments/assets/4bcc5348-2ba2-44fb-b99e-482302283c96" /> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
1 parent e099052 commit 827ea02

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

scripts/build.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -595,7 +595,8 @@ buildAndroidRunE2E(){
595595
then
596596
source $ANDROID_ENV_FILE
597597
fi
598-
cd android && ./gradlew assembleProdDebug assembleProdDebugAndroidTest -PminSdkVersion=26 -DtestBuildType=debug --build-cache --parallel && cd ..
598+
# Specify specific task name :app:TASKNAME to prevent processing other variants
599+
cd android && ./gradlew :app:assembleProdDebug :app:assembleProdDebugAndroidTest -PminSdkVersion=26 -DtestBuildType=debug --build-cache && cd ..
599600
}
600601

601602
buildIos() {

0 commit comments

Comments
 (0)