Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Qq/browser state machine #12731

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

chore: Qq/browser state machine #12731

wants to merge 3 commits into from

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Dec 17, 2024

Description

This PR adds a state machine to the browser webview's life cycle, which will update a set of browser data. This will be what we consider as the source of truth and should be the data that is used to render the browser experience.

Flow chart of the state machine
https://www.notion.so/metamask-consensys/Quality-Quest-Browser-State-Machine-15ef86d67d6880ffa49bc3fc9949576a?pvs=4

Related issues

Fixes: #12717

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Cal-L Cal-L self-assigned this Dec 17, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
24.2% Coverage on New Code (required ≥ 60%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BrowserTab - Quality Quest
1 participant