Skip to content

test: unit tests requiring to be fixed in order turn the feature flag (per-app) to ON #16144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
9 tasks
EtherWizard33 opened this issue Jun 5, 2025 · 1 comment · Fixed by #16150
Closed
9 tasks
Assignees
Labels
Per-Dapp-Selected-Network Used for PRs and issues related to Per Dapp Selected Network release-7.50.0 Issue or pull request that will be included in release 7.50.0 team-wallet-ux

Comments

@EtherWizard33
Copy link
Contributor

EtherWizard33 commented Jun 5, 2025

What is this about?

These files have failing tests need to be fix

on main:
modified: app/components/UI/PermissionsSummary/PermissionsSummary.test.tsx
modified: app/components/UI/TransactionElement/TransactionDetails/index.test.tsx
modified: app/components/Views/AccountPermissions/AccountPermissions.test.tsx
modified: app/components/Views/confirmations/components/confirm/confirm-component.test.tsx
modified: app/components/Views/confirmations/components/info-root/info-root.test.tsx
modified: app/components/Views/confirmations/components/info/switch-account-type/switch-account-type.test.tsx
modified: app/components/Views/confirmations/legacy/SendFlow/Confirm/index.test.tsx

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response

@EtherWizard33 EtherWizard33 self-assigned this Jun 5, 2025
@mobularay mobularay added Per-Dapp-Selected-Network Used for PRs and issues related to Per Dapp Selected Network team-wallet-ux labels Jun 5, 2025
@mobularay
Copy link
Contributor

mobularay commented Jun 5, 2025

FYI @sleepytanya @adonesky1 @NidhiKJha @hesterbruikman @vandan @elribonazo

@metamaskbot metamaskbot added the release-7.50.0 Issue or pull request that will be included in release 7.50.0 label Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Per-Dapp-Selected-Network Used for PRs and issues related to Per Dapp Selected Network release-7.50.0 Issue or pull request that will be included in release 7.50.0 team-wallet-ux
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants