Skip to content

chore: cp-7.50.0 Update default font from CentraNo1 to Geist #16609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

brianacnguyen
Copy link
Contributor

@brianacnguyen brianacnguyen commented Jun 23, 2025

Description

This PR updates fonts in Metamask

  • Updated default font from Centra No 1 to Geist
  • Updated all typography files to match its font name. This is important for npx react-native-asset to properly link the fonts
  • Updated font weights to be added on android only to prevent unintended bug on ios
  • Added all fonts to QA and Flask

Related issues

Fixes: #16608

Manual testing steps

  1. Run yarn setup from root
  2. Run yarn start:android or yarn start:ios
  3. Make sure all fonts are rendered correctly (https://vercel.com/font)

Screenshots/Recordings

Before

After

Android
Screenshot_1750716043

iOS
Simulator Screenshot - iPhone 15 Pro Max - 2025-06-23 at 15 04 48

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen self-assigned this Jun 23, 2025
@brianacnguyen brianacnguyen requested a review from a team as a code owner June 23, 2025 22:32
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-design-system All issues relating to design system in Mobile label Jun 23, 2025
@brianacnguyen brianacnguyen added needs-qa Any New Features that needs a full manual QA prior to being added to a release. Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking Run Smoke E2E Requires smoke E2E testing and removed Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking labels Jun 23, 2025
Copy link
Contributor

github-actions bot commented Jun 23, 2025

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 371c0b1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4202a8af-b437-4d6d-b0dd-b7fbe64c225c

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@georgewrmarshall georgewrmarshall requested a review from Copilot June 23, 2025 22:36
@brianacnguyen brianacnguyen requested review from zone-live and removed request for Copilot June 23, 2025 22:36
Copilot

This comment was marked as outdated.

@brianacnguyen brianacnguyen added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jun 23, 2025
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: ff88472
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/886b3dcf-a609-4809-b801-9ab3fe4ee3b3

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@brianacnguyen brianacnguyen force-pushed the fix/typography-android branch from ff88472 to 371c0b1 Compare June 23, 2025 22:44
@brianacnguyen brianacnguyen added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jun 23, 2025
@brianacnguyen brianacnguyen added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jun 23, 2025
Copy link
Contributor

github-actions bot commented Jun 23, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ead8374
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/33f10788-847a-4332-adfa-04797f05643b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@brianacnguyen brianacnguyen added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jun 27, 2025
Copy link
Contributor

github-actions bot commented Jun 27, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f5d2203
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2a6c16eb-6bf3-4be0-a9e7-ff1775e2951c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

zone-live
zone-live previously approved these changes Jun 30, 2025
@brianacnguyen brianacnguyen added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jun 30, 2025
Copy link
Contributor

github-actions bot commented Jun 30, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 10c04c7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ffadcbc0-a70d-446c-b66e-983bb3880df6

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@brianacnguyen brianacnguyen added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jun 30, 2025
Copy link
Contributor

github-actions bot commented Jun 30, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c47c84d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0718001b-8f56-492e-b479-cc7f0166d210

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link

@brianacnguyen brianacnguyen added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jun 30, 2025
@georgewrmarshall georgewrmarshall requested a review from Copilot June 30, 2025 23:21
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the default font used within Metamask from CentraNo1 to Geist, thereby unifying typography across the application and ensuring consistency in asset linking for the React Native project. The changes include updates to font family names in snapshot test files to reflect the new Geist font variants (Regular, Bold, Medium) and to align with platform-specific improvements.

@brianacnguyen brianacnguyen added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jun 30, 2025
@brianacnguyen brianacnguyen enabled auto-merge June 30, 2025 23:57
@brianacnguyen brianacnguyen added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Requires smoke E2E testing team-design-system All issues relating to design system in Mobile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: update default font from CentraNo1 to Geist
4 participants