You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the default font used within Metamask from CentraNo1 to Geist, thereby unifying typography across the application and ensuring consistency in asset linking for the React Native project. The changes include updates to font family names in snapshot test files to reflect the new Geist font variants (Regular, Bold, Medium) and to align with platform-specific improvements.
No QA NeededApply this label when your PR does not need any QA effort.Run Smoke E2ERequires smoke E2E testingteam-design-systemAll issues relating to design system in Mobile
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates fonts in Metamask
npx react-native-asset
to properly link the fontsRelated issues
Fixes: #16608
Manual testing steps
yarn setup
from rootyarn start:android
oryarn start:ios
Screenshots/Recordings
Before
After
Android

iOS

Pre-merge author checklist
Pre-merge reviewer checklist