test: Add e2e test for gas less swap #23507

hjetpoluru · 2025-12-01T21:41:17Z

Description

Add e2e test for the gas less swap

Changelog

CHANGELOG entry: null

Related issues

Fixes:
https://consensyssoftware.atlassian.net/browse/MMQA-1178

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds an e2e test for gasless ETH→MUSD swap, with new selectors and page actions to tap Max and verify “Included” network fee, plus mock quote data.

E2E Test:
- Add e2e/specs/swaps/gasless-swap-crosschain.spec.ts to validate gasless ETH→MUSD swap flow:
  - Taps Max, verifies Network fee shows Included, confirms swap, and asserts activity status is confirmed.
Page Object/Selectors:
- e2e/pages/swaps/QuoteView.ts:
  - Add maxLink, includedLabel getters and tapMax() action.
- e2e/selectors/swaps/QuoteView.selectors.ts:
  - Add text selectors MAX and INCLUDED.
Mocks/Fixtures:
- e2e/specs/swaps/helpers/constants.ts: add GASLESS_SWAP_QUOTES_ETH_MUSD mock response.
- Test wiring includes quote mock via setupMockRequest.

^{Written by Cursor Bugbot for commit 957c2dd. This will update automatically on new commits. Configure here.}

github-actions · 2025-12-01T21:41:26Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

e2e/specs/swaps/gasless-swap-crosschain.spec.ts

cursor · 2025-12-04T23:07:43Z

e2e/specs/swaps/gasless-swap-crosschain.spec.ts

+    jest.setTimeout(120000);
+  });
+
+  it('should complete swap ETH to MUSD with gas included', async (): Promise<void> => {


Bug: Test name uses prohibited "should" prefix (Bugbot Rules)

The test name 'should complete swap ETH to MUSD with gas included' uses the prohibited "should" prefix. According to the E2E testing guidelines, test names must not use "should" - this is a hard rule with zero exceptions. The test name needs to be action-oriented, such as 'completes swap ETH to MUSD with gas included'.

cursor · 2025-12-04T23:07:43Z

e2e/specs/swaps/gasless-swap-crosschain.spec.ts

+        await WalletView.tapWalletSwapButton();
+        await device.disableSynchronization();
+        await Assertions.expectElementToBeVisible(QuoteView.selectAmountLabel, {
+          description: 'Swap amount selection should be visible',


Bug: Assertion descriptions use prohibited "should" phrasing (Bugbot Rules)

Multiple assertion description parameters use "should" phrasing (lines 78, 87, 92, 97, 104, 112), such as 'Swap amount selection should be visible'. According to the testing guidelines, descriptions need to use action-oriented language without "should", for example 'Swap amount selection is visible' or 'Network fee label visible'.

Additional Locations (2)

e2e/specs/swaps/gasless-swap-crosschain.spec.ts#L86-L87

e2e/specs/swaps/gasless-swap-crosschain.spec.ts#L91-L112

github-actions · 2025-12-05T22:14:32Z

🔍 Smart E2E Test Selection

Selected E2E tags: SmokeTrade
Risk Level: low
AI Confidence: 95%

click to see 🤖 AI reasoning details

The changes are entirely within the E2E test infrastructure for swap functionality:

New test file: gasless-swap-crosschain.spec.ts is explicitly tagged with SmokeTrade and tests gasless swap functionality (ETH to MUSD with gas included).
Page object additions: New methods added to QuoteView.ts (maxLink, includedLabel, tapMax()) support the new gasless swap test.
Selector additions: New selectors (MAX, INCLUDED) in QuoteView.selectors.ts are used by the new page object methods.
Mock data: New constant GASLESS_SWAP_QUOTES_ETH_MUSD in constants.ts provides mock API response for the gasless swap test.

These changes:

Are completely self-contained within E2E test infrastructure
Do not modify any production application code
The new test explicitly uses the SmokeTrade tag
Only affect swap/trade testing functionality

Running SmokeTrade is sufficient as it will execute the new test and verify the swap-related test infrastructure changes work correctly.

View GitHub Actions results

cursor · 2025-12-05T22:16:27Z

e2e/specs/swaps/gasless-swap-crosschain.spec.ts

+    jest.setTimeout(120000);
+  });
+
+  it('should complete swap ETH to MUSD with gas included', async (): Promise<void> => {


Bug: Test name uses prohibited "should" prefix (Bugbot Rules)

The test name 'should complete swap ETH to MUSD with gas included' violates the E2E testing guidelines which explicitly prohibit using the prefix "should" in test names. Per the guidelines, the name could be something like 'completes swap ETH to MUSD with gas included' instead. This was also flagged in the PR discussion by @chrisleewilcox.

cursor · 2025-12-05T22:16:28Z

e2e/specs/swaps/helpers/constants.ts

+        metadata: { storage: {} },
+      },
+      destTokenAmount: '3011431',
+      minDestTokenAmount: '3759291202',


Bug: Mock data has inverted token amount values

The mock data GASLESS_SWAP_QUOTES_ETH_MUSD has destTokenAmount: '3011431' which is smaller than minDestTokenAmount: '3759291202'. This is logically backwards—the minimum received amount after slippage cannot be greater than the expected destination amount. All other quote mocks in the codebase correctly have destTokenAmount larger than minDestTokenAmount. This could cause incorrect behavior when testing UI elements that rely on these values.

sonarqubecloud · 2025-12-05T22:36:50Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

rarquevaux · 2025-12-06T00:45:38Z

e2e/specs/swaps/gasless-swap-crosschain.spec.ts

+        ],
+        testSpecificMock: async (mockServer) => {
+          // Mock ETH->MUSD quote (gasless swap)
+          await setupMockRequest(mockServer, {


I see the /getQuote call but I don't see any mock for the calls that are done after the swap is submitted. How does it work?

Add e2e test for gaseless swap

01a0d9f

metamaskbot added the team-qa QA team label Dec 1, 2025

github-actions bot added the size-M label Dec 1, 2025

hjetpoluru and others added 2 commits December 3, 2025 13:14

Merge branch 'main' into gaseless-swap-e2e

2fd2cf2

Code cleanup

275589c

hjetpoluru marked this pull request as ready for review December 4, 2025 22:42

hjetpoluru requested a review from a team as a code owner December 4, 2025 22:42

cursor bot reviewed Dec 4, 2025

View reviewed changes

e2e/specs/swaps/gasless-swap-crosschain.spec.ts Show resolved Hide resolved

e2e/specs/swaps/gasless-swap-crosschain.spec.ts Outdated Show resolved Hide resolved

e2e/specs/swaps/gasless-swap-crosschain.spec.ts Show resolved Hide resolved

Addressed review comment

07c383c

hjetpoluru added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Dec 4, 2025

cursor bot reviewed Dec 4, 2025

View reviewed changes

Merge branch 'main' into gaseless-swap-e2e

957c2dd

cursor bot reviewed Dec 5, 2025

View reviewed changes

rarquevaux reviewed Dec 6, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

test: Add e2e test for gas less swap #23507

test: Add e2e test for gas less swap #23507

hjetpoluru commented Dec 1, 2025 •

edited by cursor bot

Loading

Uh oh!

github-actions bot commented Dec 1, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor bot Dec 4, 2025

Uh oh!

cursor bot Dec 4, 2025

Uh oh!

github-actions bot commented Dec 5, 2025

Uh oh!

cursor bot Dec 5, 2025

Uh oh!

cursor bot Dec 5, 2025

Uh oh!

sonarqubecloud bot commented Dec 5, 2025

Uh oh!

rarquevaux Dec 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

test: Add e2e test for gas less swap #23507

Are you sure you want to change the base?

test: Add e2e test for gas less swap #23507

Conversation

hjetpoluru commented Dec 1, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Dec 1, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor bot Dec 4, 2025

Choose a reason for hiding this comment

Bug: Test name uses prohibited "should" prefix (Bugbot Rules)

Uh oh!

cursor bot Dec 4, 2025

Choose a reason for hiding this comment

Bug: Assertion descriptions use prohibited "should" phrasing (Bugbot Rules)

Uh oh!

github-actions bot commented Dec 5, 2025

🔍 Smart E2E Test Selection

Uh oh!

cursor bot Dec 5, 2025

Choose a reason for hiding this comment

Bug: Test name uses prohibited "should" prefix (Bugbot Rules)

Uh oh!

cursor bot Dec 5, 2025

Choose a reason for hiding this comment

Bug: Mock data has inverted token amount values

Uh oh!

sonarqubecloud bot commented Dec 5, 2025

Quality Gate passed

Uh oh!

rarquevaux Dec 6, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hjetpoluru commented Dec 1, 2025 •

edited by cursor bot

Loading