build version 7.62.89 #23647
Open
build version 7.62.89 #23647
+19
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->
## **Description**
This PR applies OTA updates to 7.62.89. It's for testing only
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
## **Changelog**
<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`
If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`
(This helps the Release Engineer do their job more quickly and
accurately)
-->
CHANGELOG entry:
## **Related issues**
Fixes:
## **Manual testing steps**
```gherkin
Feature: my feature name
Scenario: user [verb for user action]
Given [describe expected initial app state]
When user [verb for user action]
Then [describe expected outcome]
```
## **Screenshots/Recordings**
<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->
### **Before**
<!-- [screenshots/recordings] -->
### **After**
<!-- [screenshots/recordings] -->
## **Pre-merge author checklist**
- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> Bumps OTA version to v1 and shows an OTA v1 message on the App
Information screen.
>
> - **OTA**:
> - Increment `OTA_VERSION` to `v1` in `app/constants/ota.ts`.
> - **Settings UI**:
> - Add version info text indicating OTA v1 in
`app/components/Views/Settings/AppInformation/index.js`.
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
92b9efa. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| ) : null} | ||
| <Text | ||
| style={styles.versionInfo} | ||
| >{`this is OTA update v1 text`}</Text> |
There was a problem hiding this comment.
Bug: Debug text displayed to all users in production
A hardcoded test string "this is OTA update v1 text" is rendered unconditionally in the App Information settings page. Unlike the branch info above it which only appears when isQa is true, this text will be visible to all users in production builds. This appears to be debugging or placeholder text that was accidentally left in the code.
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->
## **Description**
TEST ota update v2: update on top of update
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
## **Changelog**
<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`
If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`
(This helps the Release Engineer do their job more quickly and
accurately)
-->
CHANGELOG entry:
## **Related issues**
Fixes:
## **Manual testing steps**
```gherkin
Feature: my feature name
Scenario: user [verb for user action]
Given [describe expected initial app state]
When user [verb for user action]
Then [describe expected outcome]
```
## **Screenshots/Recordings**
<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->
### **Before**
<!-- [screenshots/recordings] -->
### **After**
<!-- [screenshots/recordings] -->
## **Pre-merge author checklist**
- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> Bumps app to 7.62.89 (build 3232) across Android/iOS/CI, sets OTA
version to v2, and adds OTA update texts in App Information.
>
> - **Versioning**:
> - Android: Set `versionName`/`versionCode` to `7.62.89`/`3232` in
`android/app/build.gradle`.
> - iOS: Update `MARKETING_VERSION`/`CURRENT_PROJECT_VERSION` to
`7.62.89`/`3232` across `ios/MetaMask.xcodeproj/project.pbxproj`.
> - CI: Sync `VERSION_NAME`/`VERSION_NUMBER` (and Flask variants) in
`bitrise.yml`; bump `package.json` `version` to `7.62.89`.
> - **OTA**:
> - Set `OTA_VERSION` to `v2` in `app/constants/ota.ts`.
> - **UI**:
> - Add OTA update indicator texts in
`app/components/Views/Settings/AppInformation/index.js`.
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
e2bb0b4. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
| >{`this is OTA update v1 text`}</Text> | ||
| <Text | ||
| style={styles.versionInfo} | ||
| >{`this is OTA update v2 text`}</Text> |
There was a problem hiding this comment.
Bug: Debug placeholder text accidentally committed to production
Two debug placeholder text elements displaying "this is OTA update v1 text" and "this is OTA update v2 text" have been added to the App Information settings screen. Unlike other text in this component, these strings are unconditionally rendered (not gated by isQa or showEnvironmentInfo), use hardcoded English text instead of localized strings, and contain obvious placeholder content. These will be visible to all end users in production.
Contributor
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsAll four changed files contain only version bump changes:
These are purely metadata/configuration changes that update version identifiers. No application code, dependencies, logic, or functionality is being modified. Version bumps do not affect runtime behavior and pose no risk to any user-facing features. While package.json is marked as critical, the change is confined to the "version" field which has no impact on dependencies or application behavior. No E2E tests are necessary for these changes as they cannot break any functionality. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Bumps version to 7.62.89 (build 3246) across Android, iOS, Bitrise CI vars, and package.json.
7.62.89(build3246):versionName/versionCodeinandroid/app/build.gradle.MARKETING_VERSION/CURRENT_PROJECT_VERSIONacross targets inios/MetaMask.xcodeproj/project.pbxproj.VERSION_NAME,VERSION_NUMBER,FLASK_VERSION_NAME,FLASK_VERSION_NUMBERinbitrise.yml.versioninpackage.json.Written by Cursor Bugbot for commit 6876486. This will update automatically on new commits. Configure here.