chore(runway): cherry-pick feat: add new metrics key to transactions cp-7.61.0

[runway-github]

• feat: add new metrics key to transactions cp-7.61.0 (feat: add new metrics key to transactions cp-7.61.0 #23585)

Description

This PR adds account_hardware_type to transaction events when the
account is a hardware account.

Changelog

CHANGELOG entry: null

Related issues

Fixes:
https://consensyssoftware.atlassian.net/browse/MUL-1259?atlOrigin=eyJpIjoiNGE0MjcyYTY0YjE0NGEyNGEwNWVjZGYwYWMzYjFkMWEiLCJwIjoiaiJ9

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

No visual changes.

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor
  Docs and MetaMask Mobile
  Coding
  Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format
  if applicable
• I’ve applied the right labels on the PR (see labeling
  guidelines).
  Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the
  app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described
  in the ticket it closes and includes the necessary testing evidence such
  as recordings and or screenshots.

---

Note

Adds account_hardware_type to transaction metrics for hardware accounts and renames QR account type to "QR Hardware" across code and tests.

• Analytics/Metrics:
  • Add account_hardware_type to generateDefaultTransactionMetrics (null for non-HW; set to account type for HW via isHardwareAccount).
  • Update tests to cover hardware wallets (Ledger, QR Hardware), invalid addresses, and error cases.
• Address Utils:
  • Change getAddressAccountType to return "QR Hardware" (was "QR").
  • Update related tests to expect "QR Hardware".
• UI:
  • Update EditAccountName analytics mapping to treat "QR Hardware" as "hardware" for account_type.

^{Written by Cursor Bugbot for commit 4c200fd. This will update automatically on new commits. Configure here.}

---

Co-authored-by: Charly Chevalier [email protected] e47bcb5

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeConfirmationsRedesigned, SmokeAccounts, SmokeAnalytics, SmokeCore
• Risk Level: high
• AI Confidence: 85%

click to see 🤖 AI reasoning details

The changes affect critical parts of the application:

1. Transaction Controller Utils (CRITICAL FILE): These changes modify core transaction metrics generation in the Engine, which is used for ALL transaction types. The changes add new analytics properties for:

   • Gas payment token tracking (gas_paid_with, gas_payment_tokens_available)
   • Native asset sufficiency checking (gas_insufficient_native_asset)
   • Hardware wallet type identification (account_hardware_type)

2. Address Utility Changes: The change from 'QR' to 'QR Hardware' affects account type detection throughout the app, which impacts account management, analytics, and hardware wallet flows.

3. Scope of Impact:

   • All transaction confirmations (send, swap, approve, etc.)
   • Hardware wallet interactions (Ledger, QR-based wallets)
   • Analytics tracking for all transaction events
   • Gas fee calculations and display
   • Account management features

Selected Tags Justification:

• SmokeConfirmationsRedesigned: Transaction confirmation flows are directly impacted by gas payment and metrics changes
• SmokeAccounts: Hardware wallet account type changes and account management affected
• SmokeAnalytics: New analytics properties added to transaction metrics
• SmokeCore: Changes to Engine/transaction-controller utils affect core wallet functionality

The changes have comprehensive test coverage but touch critical transaction paths. The risk is HIGH because:

• Engine/transaction-controller is a critical component
• Changes affect all transaction types
• Hardware wallet detection changes could impact account identification
• Analytics changes span multiple transaction workflows

While the changes include thorough unit tests, E2E testing is warranted to ensure the integration works correctly across transaction flows, hardware wallet interactions, and account management.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
76.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[metamaskbot]

No release label on PR. Adding release label release-7.61.0 on PR, as PR was cherry-picked in branch 7.61.0.