Skip to content

Conversation

@matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Dec 5, 2025

Description

Bump controller versions to improve accuracy of provider and network fees in Perps and Predict deposits.

Changelog

CHANGELOG entry: Improved accuracy of provider and network fees in Perps and Predict deposits

Related issues

Fixes: #23698 #6394

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Updates MetaMask controller dependencies, notably @metamask/transaction-controller to 62.5.0 and @metamask/transaction-pay-controller to 10.4.0, plus aligned assets/network/bridge packages and remote feature flag controller.

  • Dependencies:
    • Transactions:
      • Update @metamask/transaction-controller to 62.5.0 (patch resolution and lockfile).
      • Update @metamask/transaction-pay-controller to ^10.4.0.
    • Assets/Network/Bridge:
      • Bump @metamask/assets-controllers to ^93.1.0.
      • Bump @metamask/network-controller to ^27.0.0.
      • Bump @metamask/bridge-controller to ^64.0.0 and @metamask/bridge-status-controller to ^64.0.1.
    • Feature Flags:
      • Align @metamask/remote-feature-flag-controller to ^3.0.0 where referenced.
    • Update yarn.lock to reflect the above version changes and dependency realignments.

Written by Cursor Bugbot for commit c7552f6. This will update automatically on new commits. Configure here.

@matthewwalsh0 matthewwalsh0 added the team-confirmations Push issues to confirmations team label Dec 5, 2025
@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review December 5, 2025 13:53
@socket-security
Copy link

socket-security bot commented Dec 5, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​transaction-pay-controller@​10.3.0 ⏵ 10.4.079 -2110078 -2297 -3100
Updatednpm/​@​metamask/​transaction-controller@​62.4.0 ⏵ 62.5.096 -410081 -1998 -2100

View full report

@socket-security
Copy link

socket-security bot commented Dec 5, 2025

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

View full report

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeCore, SmokeConfirmationsRedesigned, SmokeTrade, SmokeSwaps, SmokeAssets, SmokeWalletPlatform, SmokeNetworkAbstractions, SmokeStake, SmokeRamps, SmokeMultiChainPermissions
  • Risk Level: high
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

This PR updates two critical MetaMask controllers and their dependencies:

Direct Updates:

  1. @metamask/transaction-controller: 62.4.0 → 62.5.0
  2. @metamask/transaction-pay-controller: 10.3.0 → 10.4.0

Transitive/Cascading Updates (via yarn.lock):

  • @metamask/assets-controllers: 91.0.0/92.0.0 → 93.0.0/93.1.0
  • @metamask/bridge-controller: 63.2.0 → 64.0.0
  • @metamask/bridge-status-controller: 63.1.0 → 64.0.1
  • @metamask/network-controller: 26.0.0 → 27.0.0
  • @metamask/remote-feature-flag-controller: 2.0.1 → 3.0.0

These controllers are foundational to the wallet's operation:

  • TransactionController: Manages all blockchain transactions (sends, approvals, swaps, staking, etc.)
  • TransactionPayController: Handles gas fee payments, including paying with tokens other than the native token
  • BridgeController/BridgeStatusController: Powers cross-chain bridging functionality
  • AssetsControllers: Token/NFT management and display
  • NetworkController: All network connectivity and chain switching

The changes touch critical infrastructure (marked CRITICAL in package.json), containing "Controller" keyword, and affect the core transaction/confirmation flows. Though these are minor version bumps (likely bug fixes or small features), controller updates can have subtle behavioral changes that affect user flows.

Selected test suites cover:

  • SmokeCore: Core wallet functionality affected by transaction controller
  • SmokeConfirmationsRedesigned: All confirmation flows use TransactionController
  • SmokeTrade/SmokeSwaps: Trading requires transaction submission
  • SmokeAssets: Assets display uses assets-controllers
  • SmokeWalletPlatform: Core wallet and network operations
  • SmokeNetworkAbstractions: Network layer changes (network-controller update)
  • SmokeStake: Staking uses transaction flows
  • SmokeRamps: On/off ramp uses transactions
  • SmokeMultiChainPermissions: Multi-chain functionality affected by network controller

View GitHub Actions results

@matthewwalsh0
Copy link
Member Author

@SocketSecurity ignore npm/@metamask/[email protected]

@matthewwalsh0
Copy link
Member Author

@SocketSecurity ignore npm/@metamask/[email protected]

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 5, 2025

@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Dec 5, 2025
Merged via the queue into main with commit 43bd6bc Dec 5, 2025
103 checks passed
@matthewwalsh0 matthewwalsh0 deleted the chore/bump-transaction-pay-controller branch December 5, 2025 15:47
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2025
@metamaskbot metamaskbot added the release-7.62.0 Issue or pull request that will be included in release 7.62.0 label Dec 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.62.0 Issue or pull request that will be included in release 7.62.0 size-XS team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Predict: under-optimized provider fees for Predict deposits

5 participants