-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
chore(runway): cherry-pick fix(ramp): experience switcher text cp-7.61.0 #23720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(runway): cherry-pick fix(ramp): experience switcher text cp-7.61.0 #23720
Conversation
…1.0 (#23712) ## **Description** This PR updates the copy text in the "escape hatch" modals that allow users to switch between the Aggregator (classic) and Deposit (new) buy experiences. **Reason for change:** The current copy text ("Use new buy experience" / "Try new native on ramp" and "More ways to buy" / "Use a different payment provider") was confusing users about the action being performed. Users didn't realize they were switching to a completely different feature/experience. **Solution:** Updated the modal copy to be clearer about switching between versions: - **Aggregator → Native (Deposit):** "More ways to buy" / "Switch to the new version" - **Native (Deposit) → Aggregator:** "More ways to buy" / "Switch to the classic version" ## **Changelog** CHANGELOG entry: Improved clarity of the "More ways to buy" modal copy when switching between buy experiences ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/TRAM-2858 Fixes #23716 ## **Manual testing steps** ```gherkin Feature: More ways to buy escape hatch copy Scenario: user views escape hatch modal from Aggregator (classic) experience Given user is in the Aggregator buy flow When user opens the settings modal Then user sees "More ways to buy" with description "Switch to the new version" Scenario: user views escape hatch modal from Deposit (new) experience Given user is in the Deposit buy flow When user opens the configuration modal Then user sees "More ways to buy" with description "Switch to the classic version" ``` ## **Screenshots/Recordings** ### **Before** | Aggregator | Deposit | |:--:|:--:| | <img width="299" alt="before_agg" src="https://github.com/user-attachments/assets/5a01ef8b-7cad-4c2e-a149-c43cc4b6aec2" /> | <img width="299" alt="before_deposit" src="https://github.com/user-attachments/assets/f4f88802-f42d-4cf6-ae2f-61e95ad9dbae" /> | ### **After** | Aggregator | Deposit | |:--:|:--:| | <img width="299" alt="after_agg" src="https://github.com/user-attachments/assets/9b05bdb7-bae8-427c-bc3d-153fb82d895c" /> | <img width="299" alt="after_deposit" src="https://github.com/user-attachments/assets/9ec3e323-0e58-4c98-875d-219cdddba271" /> | ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --- You can drop your 4 screenshots in the Before/After sections where I've left the placeholders! <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Updates copy and tests for the buy experience switcher: “More ways to buy” with “Switch to the new version” (Aggregator) and “Switch to the classic version” (Deposit). > > - **UI copy updates** > - `fiat_on_ramp_aggregator.settings_modal`: > - `use_new_buy_experience` → `More ways to buy` > - Description → `Switch to the new version` > - `deposit.configuration_modal`: > - `more_ways_to_buy_description` → `Switch to the classic version` > - **Tests & snapshots** > - Update `SettingsModal.test.tsx` and related snapshots to assert new labels and descriptions. > - Update `ConfigurationModal` snapshot to reflect new description. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit faecee2. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsThe changes in this PR are primarily localization (UI text) updates affecting multiple features: Main Changes:
Why SmokeRamps:
Risk Assessment - Low:
Why not other tags:
Conservative approach: Running SmokeRamps will verify the user-facing text appears correctly in the ramp/buy flow, which is where the test updates occurred. |
|
|
No release label on PR. Adding release label release-7.61.0 on PR, as PR was cherry-picked in branch 7.61.0. |



Description
This PR updates the copy text in the "escape hatch" modals that allow
users to switch between the Aggregator (classic) and Deposit (new) buy
experiences.
Reason for change:
The current copy text ("Use new buy experience" / "Try new native on
ramp" and "More ways to buy" / "Use a different payment provider") was
confusing users about the action being performed. Users didn't realize
they were switching to a completely different feature/experience.
Solution:
Updated the modal copy to be clearer about switching between versions:
new version"
classic version"
Changelog
CHANGELOG entry: Improved clarity of the "More ways to buy" modal copy
when switching between buy experiences
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/TRAM-2858
Fixes #23716
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
You can drop your 4 screenshots in the Before/After sections where I've
left the placeholders!
Note
Renames/updates the “More ways to buy” copy across Aggregator and Deposit settings modals and synchronizes tests, snapshots, and English locales.
settings_modal:use_new_buy_experience→More ways to buywith descriptionSwitch to the new version.configuration_modal:more_ways_to_buy_description→Switch to the classic version.SettingsModal.test.tsxnames/expectations for the new copy and keep navigation/analytics assertions intact.locales/languages/en.jsonkeys/strings to reflect new wording in both flows.Written by Cursor Bugbot for commit b2967c7. This will update automatically on new commits. Configure here.
2f8ab08