Skip to content

Conversation

@nickewansmith
Copy link
Contributor

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeStake, SmokeConfirmationsRedesigned, SmokeTrade
  • Risk Level: medium
  • AI Confidence: 75%
click to see 🤖 AI reasoning details

The PR contains two types of changes:

  1. Version bumps only (low risk): package.json, bitrise.yml, android/app/build.gradle, and ios/MetaMask.xcodeproj/project.pbxproj all have changes limited to version number updates (7.62.0 → 7.62.123, build numbers updated). These don't require E2E testing.

  2. Earn/mUSD Conversion feature updates (medium risk): The majority of changes are to the Earn module, specifically:

    • Modified useMusdConversion hook to handle education screen redirects within the hook itself (moving logic from individual components)
    • New useMusdConversionTokens helper function getMusdOutputChainId for determining output chain
    • New useCustomAmount hook for confirmations to handle mUSD-specific output amount display
    • New OutputAmountTag UI component
    • Modified CustomAmountInfo to support overrideContent prop for mUSD conversion UI
    • Updated StakeButton, EarnBalance, MusdConversionAssetListCta, and MusdConversionAssetOverviewCta to use the refactored hook logic
    • Removed nestedTransactions from transaction params in the conversion flow

These changes refactor how the mUSD conversion flow handles navigation and display, consolidating education screen logic and adding new output amount display. This affects:

  • Stake button functionality (can trigger mUSD conversion)
  • Earn balance display (shows convertible stablecoins)
  • Confirmation screens for mUSD conversion

Selected tags:

  • SmokeStake: StakeButton is modified, EarnBalance is updated
  • SmokeConfirmationsRedesigned: CustomAmountInfo and musd-conversion-info confirmation components are modified
  • SmokeTrade: Stake tests use SmokeTrade tag, and the earn/stake functionality overlaps with trading features

View GitHub Actions results

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 5, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
40.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants