Skip to content

Conversation

@weitingsun
Copy link
Contributor

@weitingsun weitingsun commented Dec 5, 2025

Description

In this PR, we are mocking the value from getFullVersion so the tests won't fail if OTA version is modified.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@weitingsun weitingsun requested a review from a team as a code owner December 5, 2025 22:01
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Dec 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

The only change in this PR is a modification to a unit test file (app/components/Views/Settings/AppInformation/index.test.tsx). The diff shows only the addition of a mock for the getFullVersion function from the OTA constants module. This mock makes the function a pass-through so that unit tests don't depend on the OTA_VERSION constant value.

This is purely a unit test infrastructure improvement:

  1. No production code is modified
  2. No E2E test infrastructure is affected
  3. The change only improves unit test reliability by making them independent of environment variables
  4. The AppInformation component itself is unchanged

Since no production code, E2E test infrastructure, or user-facing functionality is modified, no E2E test tags need to be run.

View GitHub Actions results

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.82%. Comparing base (e85bc15) to head (70aa277).
⚠️ Report is 41 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #23738      +/-   ##
==========================================
+ Coverage   78.80%   78.82%   +0.02%     
==========================================
  Files        4033     4043      +10     
  Lines      105201   105472     +271     
  Branches    21157    21220      +63     
==========================================
+ Hits        82903    83140     +237     
- Misses      16516    16535      +19     
- Partials     5782     5797      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 5, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants