-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
chore(runway): cherry-pick fix: correct swaps network ordering cp:7.61.0 #23749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/7.61.0
Are you sure you want to change the base?
Conversation
…1.0 (#23686) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Fixes the network ordering to include Tron between Solana and Base <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: Updated swaps network picker ordering ## **Related issues** Fixes: #23687 ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Adds Tron to bridge networks, positions it after Solana in popularity ordering, and includes TRX in source network balance sorting and tests. > > - **Bridge UI**: > - Update `BridgeDestNetworksBar.tsx` `ChainPopularity` to include `TrxScope.Mainnet` after `SolScope.Mainnet` and shift subsequent rankings. > - **Sorting/Logic**: > - Extend `useSortedSourceNetworks` to compute/sort by Tron (`TrxScope.Mainnet`) fiat totals alongside Solana and Bitcoin. > - **Mocks/State**: > - Add Tron account, native asset (`tron:728126428/slip44:195`), balances, metadata, rates, and controller entries in `_mocks_/initialState.ts`. > - **Tests/Snapshots**: > - Update selectors and snapshots to display/select Tron across source/dest network and token selectors; adjust expectations to include `TrxScope.Mainnet`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit ed48008. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsAnalysis SummaryThe changes in this PR add support for Tron (TRX) network to the Bridge functionality: Changed Files Analysis:
Impact Assessment:Direct Impact:
Why SmokeTrade:
Why SmokeNetworkExpansion:
Risk Level: Medium because:
Not selecting other tags because:
The changes are well-contained within Bridge components with good test coverage, justifying medium risk and high confidence. |
|



Description
Fixes the network ordering to include Tron between Solana and Base
Changelog
CHANGELOG entry: Updated swaps network picker ordering
Related issues
Fixes: #23687
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Adds Tron (TRX) as a supported bridge network/tokens and updates popularity ordering to place Tron after Solana, with corresponding state, hooks, and tests updated.
ChainPopularityinBridgeDestNetworksBar.tsx(after Solana)._mocks_/initialState.tswith Tron account, balances, assets metadata, conversion rates, and inclusion inRemoteFeatureFlagControllerandMultichainNetworkController.useSortedSourceNetworksto compute and sort by Tron fiat totals alongside Solana/Bitcoin/EVM.BridgeSourceNetworkSelector.test.tsxto includeTrxScope.Mainnetin applied selections and update ordering assertions.Written by Cursor Bugbot for commit 16d5ae4. This will update automatically on new commits. Configure here.
47aef8d