Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sentry] eth-json-rpc-middleware not handling http 429 #9912

Closed
sentry-io bot opened this issue Jun 10, 2024 · 3 comments
Closed

[Sentry] eth-json-rpc-middleware not handling http 429 #9912

sentry-io bot opened this issue Jun 10, 2024 · 3 comments
Labels
area-Sentry Issue from Sentry regression-prod-7.23.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-wallet-api-platform team-wallet-framework type-bug Something isn't working

Comments

@sentry-io
Copy link

sentry-io bot commented Jun 10, 2024

@metamask/eth-json-rpc-middleware/dist/fetch.js not handling http 429 retry response.

Sentry Issue: METAMASK-MOBILE-2FZW

Error: Internal JSON-RPC error.
  at construct (native)
  at apply (native)
  at _construct (node_modules/@babel/runtime/helpers/construct.js:4:65)
  at Wrapper (node_modules/@babel/runtime/helpers/wrapNativeSuper.js:17:14)
  at construct (native)
...
(23 additional frame(s) were not displayed)
@metamaskbot metamaskbot changed the title eth-json-rpc-middleware not handling http 429 [Sentry] eth-json-rpc-middleware not handling http 429 Jun 10, 2024
@metamaskbot metamaskbot added type-bug Something isn't working area-Sentry Issue from Sentry regression-prod-7.23.0 labels Jun 10, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Jun 10, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Jun 10, 2024
@gauthierpetetin gauthierpetetin added the Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking label Jun 14, 2024
@desi
Copy link
Contributor

desi commented Jul 18, 2024

In the fetch middleware we are using 418 for rate limit .. should we be using 418 and 429 for rate limit. -- see MetaMask/eth-json-rpc-middleware#212

And additional issues that are related are:
MetaMask/eth-json-rpc-middleware#210
MetaMask/eth-json-rpc-middleware#207

So for this ticket, similar to https://app.zenhub.com/workspaces/wallet-framework-621e46b4d7103800171d1b02/issues/gh/metamask/metamask-extension/22286
The main issue is we aren't catching the error. It may have a common solution or maybe not but calling out the connection

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Issues that have not had activity in the last 90 days label Nov 11, 2024
Copy link
Contributor

This issue was closed because there has been no follow activity in 7 days. If you feel this was closed in error please provide evidence on the current production app in a new issue or comment in the existing issue to a maintainer. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 18, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Nov 18, 2024
@mcmire mcmire reopened this Nov 27, 2024
@github-project-automation github-project-automation bot moved this from Fixed to To be fixed in Bugs by team Nov 27, 2024
@github-actions github-actions bot removed the stale Issues that have not had activity in the last 90 days label Nov 27, 2024
@desi desi closed this as completed Dec 11, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Sentry Issue from Sentry regression-prod-7.23.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-wallet-api-platform team-wallet-framework type-bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

5 participants