Skip to content

Commit 8c78ec3

Browse files
authored
chore: bump better-sqlite3 and revert rebuild script (#702)
Closes: #672 Updates better-sqlite3 to improve compiler compatibility. Removes now unnecessary `-std=c++20` compiler directive from native rebuild script.
1 parent fb94a29 commit 8c78ec3

File tree

3 files changed

+7
-19
lines changed

3 files changed

+7
-19
lines changed

packages/kernel-store/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@
7979
"dependencies": {
8080
"@metamask/logger": "workspace:^",
8181
"@sqlite.org/sqlite-wasm": "^3.49.1-build3",
82-
"better-sqlite3": "^11.9.1",
82+
"better-sqlite3": "^12.4.1",
8383
"ses": "^1.14.0"
8484
},
8585
"devDependencies": {

scripts/rebuild-native.sh

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -20,18 +20,6 @@ if [ "$FORCE_REBUILD" -eq 1 ]; then
2020
echo "🔁 Force rebuild enabled"
2121
fi
2222

23-
# Detect Node.js version and set C++ standard for Node.js v24+
24-
# Node.js v24+ requires C++20 due to V8 API changes
25-
NODE_VERSION=$(node -v | cut -d'v' -f2 | cut -d'.' -f1)
26-
if [ "$NODE_VERSION" -ge 24 ]; then
27-
# Set C++20 flags for node-gyp builds
28-
export CXXFLAGS="${CXXFLAGS} -std=c++20"
29-
export CPPFLAGS="${CPPFLAGS} -std=c++20"
30-
# npm/node-gyp also respects npm_config_* environment variables
31-
export npm_config_cxxflags="${npm_config_cxxflags} -std=c++20"
32-
echo "🔧 Node.js v${NODE_VERSION} detected: Using C++20 for native builds"
33-
fi
34-
3523
# Check and rebuild better-sqlite3
3624
if [ -d node_modules/better-sqlite3 ] && \
3725
{ [ "$FORCE_REBUILD" -eq 1 ] || \
@@ -59,7 +47,7 @@ fi
5947
# Check and rebuild tree-sitter
6048
if [ -d node_modules/tree-sitter ] && \
6149
{ [ "$FORCE_REBUILD" -eq 1 ] || \
62-
[ ! -f node_modules/tree-sitter/build/Release/tree_sitter.node ]; \
50+
[ ! -f node_modules/tree-sitter/build/Release/tree_sitter_runtime_binding.node ]; \
6351
}; then
6452
echo "🔨 Building tree-sitter..."
6553
if ! npm rebuild tree-sitter; then

yarn.lock

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2225,7 +2225,7 @@ __metadata:
22252225
"@typescript-eslint/parser": "npm:^8.29.0"
22262226
"@typescript-eslint/utils": "npm:^8.29.0"
22272227
"@vitest/eslint-plugin": "npm:^1.3.4"
2228-
better-sqlite3: "npm:^11.9.1"
2228+
better-sqlite3: "npm:^12.4.1"
22292229
depcheck: "npm:^1.4.7"
22302230
eslint: "npm:^9.23.0"
22312231
eslint-config-prettier: "npm:^10.1.1"
@@ -6341,14 +6341,14 @@ __metadata:
63416341
languageName: node
63426342
linkType: hard
63436343

6344-
"better-sqlite3@npm:^11.9.1":
6345-
version: 11.9.1
6346-
resolution: "better-sqlite3@npm:11.9.1"
6344+
"better-sqlite3@npm:^12.4.1":
6345+
version: 12.4.6
6346+
resolution: "better-sqlite3@npm:12.4.6"
63476347
dependencies:
63486348
bindings: "npm:^1.5.0"
63496349
node-gyp: "npm:latest"
63506350
prebuild-install: "npm:^7.1.1"
6351-
checksum: 10/bfd820e7a32d6f8bbc43607ccb3a27d89ce20923118bf5c5f6c1550b55e8ce3b1c69db2273131791d866a078be66d3b15e6fedea96824cd3aeac3e492c61d1e1
6351+
checksum: 10/383b1acc7c9f03e0677ab2aad5d3a44b4d36565396b1d10dfa5ebcf7840799afeb180c2b7c9813d7ffd1d5c92e497d5c9c52118fe7c5839987df87370df69943
63526352
languageName: node
63536353
linkType: hard
63546354

0 commit comments

Comments
 (0)